[PR #1891] [CLOSED] Fatal typo in docker-compose.yml for meilisearch container #1920

New issue

Closed

opened 2026-03-02 11:59:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1891
Author: @dierochade
Created: 9/5/2025
Status: ❌ Closed

Base: main ← Head: patch-1

📝 Commits (2)

4f855f0 Fatal typo in docker-compose.yml for meilisearch container
4fc0088 Update docker-compose.yml

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 docker/docker-compose.yml (+1 -1)

📄 Description

the blueprint fort he compose contains

environment:
  - MEILI_NO_ANALYTICS="true"

This should be a boolean, but is formatted as string.

Leads to:

error: invalid value '"true"' for '--no-analytics'
[possible values: true, false]

and breaks the container at startup

Summary by CodeRabbit

Bug Fixes
- Ensured the search service’s telemetry is reliably disabled in container deployments by correcting a configuration value to the expected boolean.
- Prevents intermittent analytics pings that could occur due to a mis-typed configuration, improving user privacy and compliance.
- Aligns runtime configuration with the service’s expected types to avoid environment-specific inconsistencies (local, CI, staging).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1891 **Author:** [@dierochade](https://github.com/dierochade) **Created:** 9/5/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`4f855f0`](https://github.com/karakeep-app/karakeep/commit/4f855f0539758b8df98889a6197d8fc1fe224109) Fatal typo in docker-compose.yml for meilisearch container - [`4fc0088`](https://github.com/karakeep-app/karakeep/commit/4fc0088aedd4e4e9a4bbc543a5074621c3bb8092) Update docker-compose.yml ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docker/docker-compose.yml` (+1 -1) </details> ### 📄 Description the blueprint fort he compose contains environment: - MEILI_NO_ANALYTICS="true" This should be a boolean, but is formatted as string. Leads to: error: invalid value '"true"' for '--no-analytics' [possible values: true, false] and breaks the container at startup  ## Summary by CodeRabbit * **Bug Fixes** * Ensured the search service’s telemetry is reliably disabled in container deployments by correcting a configuration value to the expected boolean. * Prevents intermittent analytics pings that could occur due to a mis-typed configuration, improving user privacy and compliance. * Aligns runtime configuration with the service’s expected types to avoid environment-specific inconsistencies (local, CI, staging).  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>