[PR #1847] [MERGED] feat: Support video uploads and attachments #1910

New issue

Closed

opened 2026-03-02 11:59:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1847
Author: @packetmonkey
Created: 8/17/2025
Status: ✅ Merged
Merged: 8/22/2025
Merged by: @MohamedBassem

Base: main ← Head: upload-videos

📝 Commits (1)

fb40fb4 feat: Support video uploads and attachments

📊 Changes

2 files changed (+11 additions, -1 deletions)

View changed files

📝 packages/shared/assetdb.ts (+10 -0)
📝 packages/trpc/lib/attachments.ts (+1 -1)

📄 Description

This commit allows the following mime types to be uploaded and attached as video assets on bookmarks.

video/mp4
video/webm
video/x-matroska

This seems to be the minimal diff that adds the functionality in my dev environment. This change only adds the functionality to the API and makes no UI facing changes. Videos uploaded and attached using the API appear on the related bookmark similar to a video added using the native yt-dlp functionality.

I'm happy to make any changes needed to help land this.

Thanks for the amazing app!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1847 **Author:** [@packetmonkey](https://github.com/packetmonkey) **Created:** 8/17/2025 **Status:** ✅ Merged **Merged:** 8/22/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `upload-videos` --- ### 📝 Commits (1) - [`fb40fb4`](https://github.com/karakeep-app/karakeep/commit/fb40fb4c97ceaf46e313afde300bbb769c8a0768) feat: Support video uploads and attachments ### 📊 Changes **2 files changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/shared/assetdb.ts` (+10 -0) 📝 `packages/trpc/lib/attachments.ts` (+1 -1) </details> ### 📄 Description This commit allows the following mime types to be uploaded and attached as video assets on bookmarks. - video/mp4 - video/webm - video/x-matroska This seems to be the minimal diff that adds the functionality in my dev environment. This change only adds the functionality to the API and makes no UI facing changes. Videos uploaded and attached using the API appear on the related bookmark similar to a video added using the native yt-dlp functionality. I'm happy to make any changes needed to help land this. Thanks for the amazing app! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:43 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1910

No description provided.

Rows
Columns