[PR #1846] [MERGED] fix(mobile): remove type: module so expo works #1909

New issue

Closed

opened 2026-03-02 11:59:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1846
Author: @xuatz
Created: 8/16/2025
Status: ✅ Merged
Merged: 8/20/2025
Merged by: @MohamedBassem

Base: main ← Head: fix/expo-release-build

📝 Commits (1)

3d852c1 fix(mobile): remove type: module so expo works

📊 Changes

6 files changed (+102 additions, -101 deletions)

View changed files

➕ apps/mobile/app.config.js (+102 -0)
➖ apps/mobile/app.json (+0 -100)
📝 apps/mobile/metro.config.js (+0 -0)
📝 apps/mobile/package.json (+0 -1)
📝 apps/mobile/plugins/camera-not-required.js (+0 -0)
📝 apps/mobile/plugins/trust-local-certs.js (+0 -0)

📄 Description

Summary

remove "type": "module" from apps/mobile/package.json because it breaks expo run:android
sneakily convert app.json to app.config.js

Details

I realise that #1845 wasn't sufficient to make a release build locally to install on my physical android device. However after installing, the app seems to be broken.

I tried to revert "type": "module" and it seems to fix the release build.

Perhaps we can revert it for now, so that the expo build will be fixed on main, while we can separately find time to look into how to get esm working for expo.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1846 **Author:** [@xuatz](https://github.com/xuatz) **Created:** 8/16/2025 **Status:** ✅ Merged **Merged:** 8/20/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `fix/expo-release-build` --- ### 📝 Commits (1) - [`3d852c1`](https://github.com/karakeep-app/karakeep/commit/3d852c15cfd9a9cd9bf1521c2d5e0913b6987823) fix(mobile): remove type: module so expo works ### 📊 Changes **6 files changed** (+102 additions, -101 deletions) <details> <summary>View changed files</summary> ➕ `apps/mobile/app.config.js` (+102 -0) ➖ `apps/mobile/app.json` (+0 -100) 📝 `apps/mobile/metro.config.js` (+0 -0) 📝 `apps/mobile/package.json` (+0 -1) 📝 `apps/mobile/plugins/camera-not-required.js` (+0 -0) 📝 `apps/mobile/plugins/trust-local-certs.js` (+0 -0) </details> ### 📄 Description ## Summary * remove `"type": "module"` from apps/mobile/package.json because it breaks `expo run:android` * sneakily convert app.json to app.config.js ## Details I realise that #1845 wasn't sufficient to make a release build locally to install on my physical android device. However after installing, the app seems to be broken. I tried to revert `"type": "module"` and it seems to fix the release build. Perhaps we can revert it for now, so that the expo build will be fixed on `main`, while we can separately find time to look into how to get esm working for expo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:43 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1909

No description provided.

Rows
Columns