[PR #1845] [MERGED] fix(mobile): change to metro.config.cjs since migrating to type: module #1908

New issue

Closed

opened 2026-03-02 11:59:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1845
Author: @xuatz
Created: 8/16/2025
Status: ✅ Merged
Merged: 8/16/2025
Merged by: @MohamedBassem

Base: main ← Head: fix/broken-expo-start

📝 Commits (1)

a7d84fb fix(mobile): change to metro.config.cjs since migrating to type: module

📊 Changes

4 files changed (+2 additions, -2 deletions)

View changed files

📝 apps/mobile/app.json (+2 -2)
📝 apps/mobile/metro.config.cjs (+0 -0)
📝 apps/mobile/plugins/camera-not-required.cjs (+0 -0)
📝 apps/mobile/plugins/trust-local-certs.cjs (+0 -0)

📄 Description

Summary

change to use .cjs

Details

Since github.com/karakeep-app/karakeep@8f1cb065d7 it seems like expo start doesn't work anymore.

It seems like we can address this by using .cjs

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1845 **Author:** [@xuatz](https://github.com/xuatz) **Created:** 8/16/2025 **Status:** ✅ Merged **Merged:** 8/16/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `fix/broken-expo-start` --- ### 📝 Commits (1) - [`a7d84fb`](https://github.com/karakeep-app/karakeep/commit/a7d84fbee7f206558806265c76a9940b7ef7a539) fix(mobile): change to metro.config.cjs since migrating to type: module ### 📊 Changes **4 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `apps/mobile/app.json` (+2 -2) 📝 `apps/mobile/metro.config.cjs` (+0 -0) 📝 `apps/mobile/plugins/camera-not-required.cjs` (+0 -0) 📝 `apps/mobile/plugins/trust-local-certs.cjs` (+0 -0) </details> ### 📄 Description ## Summary * change to use .cjs ## Details Since https://github.com/karakeep-app/karakeep/commit/8f1cb065d77c55dfb2e4d0df08a17160e7a8bc3f it seems like `expo start` doesn't work anymore. It seems like we can address this by using .cjs * https://github.com/expo/eas-cli/issues/1854 * https://github.com/facebook/metro/commit/692293339e3b9f542f7b83c04bdccf46fef05766 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:42 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1908

No description provided.

Rows
Columns