[PR #1762] fix(mobile): android share intent stuck on hoarding screen #1898

Open
opened 2026-03-02 11:59:40 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1762
Author: @xuatz
Created: 7/22/2025
Status: 🔄 Open

Base: mainHead: fix/1508


📝 Commits (5)

  • ab4d277 feat(mobile): add APP_VARIANT to make it easier to install multiple variants
  • 3a9d27d update docs
  • c20b161 update docs
  • 96dc704 update docs
  • e85f629 fix(mobile): android share intent stuck on hoarding screen

📊 Changes

7 files changed (+112 additions, -32 deletions)

View changed files

📝 apps/mobile/app.config.js (+9 -3)
📝 apps/mobile/app/sharing.tsx (+31 -20)
📝 apps/mobile/eas.json (+4 -1)
📝 apps/mobile/package.json (+5 -0)
📝 docs/versioned_docs/version-v0.29.0/07-development/01-setup.md (+39 -4)
📝 docs/versioned_docs/version-v0.30.0/08-development/01-setup.md (+22 -4)
📝 package.json (+2 -0)

📄 Description

Summary

  • Fix race condition by moving resetShareIntent() to success/error callbacks
  • Add validation to ensure share intent data exists before processing
  • Upgrade expo-share-intent from 3.0.0 to 3.2.3 to fix Android timing issues (maybe)
  • Add Android-specific debug logging for share intent troubleshooting
  • Replace "Hoarding/Hoarded" terminology with "Saving/Saved"
  • Update app.json to app.config.js to support dev variant

Resolves #513

loosely related to #237 if we decide to handle the share intent implementation ourselves from scratch

Notes

While the fix was focused on android, there might be a non-zero chance that #1508 might be accidentally fixed as well. Should monitor this after a new ios version is released.


I'm installing the dev variant on my device and trying it out for maybe a week, to be sure that the problem is completely fixed. So far so good.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1762 **Author:** [@xuatz](https://github.com/xuatz) **Created:** 7/22/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/1508` --- ### 📝 Commits (5) - [`ab4d277`](https://github.com/karakeep-app/karakeep/commit/ab4d277cf62e904edbc2ef4bb7efa0faedddae41) feat(mobile): add APP_VARIANT to make it easier to install multiple variants - [`3a9d27d`](https://github.com/karakeep-app/karakeep/commit/3a9d27d078c85cc2ea494b820a99cd6ad63936e7) update docs - [`c20b161`](https://github.com/karakeep-app/karakeep/commit/c20b16197429352fdc7611e74d7f9fef470b2a88) update docs - [`96dc704`](https://github.com/karakeep-app/karakeep/commit/96dc70473c2ea027a4d311eed080363eb94545c0) update docs - [`e85f629`](https://github.com/karakeep-app/karakeep/commit/e85f6295464f51e3e23c60923dbd26512b226aff) fix(mobile): android share intent stuck on hoarding screen ### 📊 Changes **7 files changed** (+112 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `apps/mobile/app.config.js` (+9 -3) 📝 `apps/mobile/app/sharing.tsx` (+31 -20) 📝 `apps/mobile/eas.json` (+4 -1) 📝 `apps/mobile/package.json` (+5 -0) 📝 `docs/versioned_docs/version-v0.29.0/07-development/01-setup.md` (+39 -4) 📝 `docs/versioned_docs/version-v0.30.0/08-development/01-setup.md` (+22 -4) 📝 `package.json` (+2 -0) </details> ### 📄 Description ## Summary - Fix race condition by moving resetShareIntent() to success/error callbacks - Add validation to ensure share intent data exists before processing - Upgrade expo-share-intent from 3.0.0 to 3.2.3 to fix Android timing issues (maybe) - https://github.com/achorein/expo-share-intent/pull/156 - Add Android-specific debug logging for share intent troubleshooting - Replace "Hoarding/Hoarded" terminology with "Saving/Saved" - Update app.json to app.config.js to support dev variant - https://docs.expo.dev/build-reference/variants/ Resolves #513 loosely related to #237 if we decide to handle the share intent implementation ourselves from scratch ## Notes While the fix was focused on android, there might be a non-zero chance that #1508 might be accidentally fixed as well. Should monitor this after a new ios version is released. --- I'm installing the `dev` variant on my device and trying it out for maybe a week, to be sure that the problem is completely fixed. So far so good. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#1898
No description provided.