starred/karakeep

Fork 0

mirror of https://github.com/karakeep-app/karakeep.git synced 2026-04-25 07:56:05 +03:00

[PR #1723] [MERGED] feat(mobile): Add user setting for default bookmark view mode #1886

New issue

Closed

opened 2026-03-02 11:59:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1723
Author: @xuatz
Created: 7/11/2025
Status: ✅ Merged
Merged: 7/17/2025
Merged by: @MohamedBassem

Base: main ← Head: feat/1603

📝 Commits (8)

dafb2cf feat(mobile): add user setting for default bookmark view mode
cf830a4 regen db migration script
fcab6e1 clean up implementation
f861994 Update docs/docs/07-Development/01-setup.md
87b3972 Update GEMINI.md
8000020 use local setting instead of storing value in db
9984a58 improve start-dev.sh to also handle for db migration
cea4d13 rename mobileBookmarkClickDefaultViewMode to defaultBookmarkView for consistency

📊 Changes

11 files changed (+214 additions, -10 deletions)

View changed files

➕ .claude/settings.json (+9 -0)
📝 .gitignore (+1 -0)
📝 GEMINI.md (+1 -0)
📝 apps/mobile/app/dashboard/(tabs)/settings.tsx (+26 -1)
📝 apps/mobile/app/dashboard/_layout.tsx (+8 -0)
📝 apps/mobile/app/dashboard/bookmarks/[slug]/index.tsx (+6 -3)
➕ apps/mobile/app/dashboard/settings/bookmark-default-view.tsx (+68 -0)
📝 apps/mobile/lib/settings.ts (+10 -1)
📝 docs/docs/07-Development/01-setup.md (+58 -2)
📝 docs/docs/07-Development/03-database.md (+1 -1)
📝 start-dev.sh (+26 -2)

📄 Description

Summary

Adds a new user setting for default bookmark view mode on mobile devices
Allows users to choose between "Reader" and "Browser" as their preferred default view when opening bookmarks
Setting is stored locally on the mobile device for instant access and offline capability

Changes Made

Added mobileBookmarkClickDefaultViewMode setting to mobile app's local settings
Implemented settings UI in mobile Settings > Default Bookmark View
Updated bookmark view component to use the user's preferred default view mode
Default value is "Reader" for new users

User Experience

Users can now set their preferred default view mode (Reader or Browser) for bookmarks
The setting is applied immediately when opening bookmarks on mobile
No network calls required - setting is stored locally for better performance
Setting persists across app sessions

Screenshots/Demo

Tested on ios simulator

I've also tested on the android app on device, connected to a karakeep server on v0.25.0 to make sure that the latest version of the app works even on older server instances.

Resolves #1603

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1723 **Author:** [@xuatz](https://github.com/xuatz) **Created:** 7/11/2025 **Status:** ✅ Merged **Merged:** 7/17/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `feat/1603` --- ### 📝 Commits (8) - [`dafb2cf`](https://github.com/karakeep-app/karakeep/commit/dafb2cf8131d2221c444381779339463edfd9809) feat(mobile): add user setting for default bookmark view mode - [`cf830a4`](https://github.com/karakeep-app/karakeep/commit/cf830a49c33b5048bfda265a72624d478526be57) regen db migration script - [`fcab6e1`](https://github.com/karakeep-app/karakeep/commit/fcab6e131942d57e133753805161f492ea510ca4) clean up implementation - [`f861994`](https://github.com/karakeep-app/karakeep/commit/f8619945efb6123a2857160d8250be6aac40a86b) Update docs/docs/07-Development/01-setup.md - [`87b3972`](https://github.com/karakeep-app/karakeep/commit/87b397269b9af499b53e0b5c947807d20288d5d3) Update GEMINI.md - [`8000020`](https://github.com/karakeep-app/karakeep/commit/80000204334e41ea6477824257230fefc0518b5b) use local setting instead of storing value in db - [`9984a58`](https://github.com/karakeep-app/karakeep/commit/9984a58b874979ee4c57f19b04b3fe67c2b0de53) improve start-dev.sh to also handle for db migration - [`cea4d13`](https://github.com/karakeep-app/karakeep/commit/cea4d13e1286ac336188c1a2a1235ef45a41bc5b) rename mobileBookmarkClickDefaultViewMode to defaultBookmarkView for consistency ### 📊 Changes **11 files changed** (+214 additions, -10 deletions) <details> <summary>View changed files</summary> ➕ `.claude/settings.json` (+9 -0) 📝 `.gitignore` (+1 -0) 📝 `GEMINI.md` (+1 -0) 📝 `apps/mobile/app/dashboard/(tabs)/settings.tsx` (+26 -1) 📝 `apps/mobile/app/dashboard/_layout.tsx` (+8 -0) 📝 `apps/mobile/app/dashboard/bookmarks/[slug]/index.tsx` (+6 -3) ➕ `apps/mobile/app/dashboard/settings/bookmark-default-view.tsx` (+68 -0) 📝 `apps/mobile/lib/settings.ts` (+10 -1) 📝 `docs/docs/07-Development/01-setup.md` (+58 -2) 📝 `docs/docs/07-Development/03-database.md` (+1 -1) 📝 `start-dev.sh` (+26 -2) </details> ### 📄 Description ## Summary - Adds a new user setting for default bookmark view mode on mobile devices - Allows users to choose between "Reader" and "Browser" as their preferred default view when opening bookmarks - Setting is stored locally on the mobile device for instant access and offline capability ## Changes Made - Added `mobileBookmarkClickDefaultViewMode` setting to mobile app's local settings - Implemented settings UI in mobile Settings > Default Bookmark View - Updated bookmark view component to use the user's preferred default view mode - Default value is "Reader" for new users ## User Experience - Users can now set their preferred default view mode (Reader or Browser) for bookmarks - The setting is applied immediately when opening bookmarks on mobile - No network calls required - setting is stored locally for better performance - Setting persists across app sessions ## Screenshots/Demo ### Tested on ios simulator <img src="https://github.com/user-attachments/assets/5b2ef1c3-9158-40ad-a663-f93cea28c674" height=400 /> I've also tested on the android app on device, connected to a karakeep server on v0.25.0 to make sure that the latest version of the app works even on older server instances. Resolves #1603 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:37 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-02 11:59:46 +03:00

[PR #1886] feat: bookmark reminder #1919

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1886

No description provided.

Rows
Columns