[PR #1649] [MERGED] feat(admin): add confirmation dialog for user deletion (#1648) #1874

New issue

Closed

opened 2026-03-02 11:59:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1649
Author: @deepanshu2711
Created: 6/21/2025
Status: ✅ Merged
Merged: 6/21/2025
Merged by: @MohamedBassem

Base: main ← Head: feat/admin-delete-user-confirmation-1648

📝 Commits (2)

69b50c4 feat(admin): add confirmation dialog for user deletion (#1648)
6a309e9 No need to manage dialog state

📊 Changes

2 files changed (+32 additions, -10 deletions)

View changed files

📝 apps/web/components/admin/UserList.tsx (+31 -10)
📝 apps/web/lib/i18n/locales/en/translation.json (+1 -0)

📄 Description

This PR enhances the user deletion UX in the Admin User List by adding a confirmation dialog to prevent accidental deletions

Closes #1648

🧾 Changes Made:

💬Action confirmation dialog (ActionConfirmingDialog) wraps the delete button for each user.
🧠 State: Added local userToDelete state to manage dialog visibility and context.
🎨 Updated translation file:
Added: "delete_user_confirm_description": "Are you sure you want to delete user "{{name}}"?"

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1649 **Author:** [@deepanshu2711](https://github.com/deepanshu2711) **Created:** 6/21/2025 **Status:** ✅ Merged **Merged:** 6/21/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `feat/admin-delete-user-confirmation-1648` --- ### 📝 Commits (2) - [`69b50c4`](https://github.com/karakeep-app/karakeep/commit/69b50c454eb1264a661a8de5eb654eb9ef7e21ec) feat(admin): add confirmation dialog for user deletion (#1648) - [`6a309e9`](https://github.com/karakeep-app/karakeep/commit/6a309e9d16f908dc96bcc6a39d834e597f2e9fb8) No need to manage dialog state ### 📊 Changes **2 files changed** (+32 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/components/admin/UserList.tsx` (+31 -10) 📝 `apps/web/lib/i18n/locales/en/translation.json` (+1 -0) </details> ### 📄 Description This PR enhances the user deletion UX in the Admin User List by adding a confirmation dialog to prevent accidental deletions Closes #1648 🧾 Changes Made: 💬Action confirmation dialog (ActionConfirmingDialog) wraps the delete button for each user. 🧠 State: Added local userToDelete state to manage dialog visibility and context. 🎨 Updated translation file: Added: "delete_user_confirm_description": "Are you sure you want to delete user \"{{name}}\"?" ![Karakeep](https://github.com/user-attachments/assets/10a54f66-71d4-44dc-8e74-4a57081e3c00) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:34 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1874

No description provided.

Rows
Columns