[PR #1642] [MERGED] chore: migrate away from eslint to oxlint #1873

Closed
opened 2026-03-02 11:59:33 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1642
Author: @xuatz
Created: 6/20/2025
Status: Merged
Merged: 6/22/2025
Merged by: @MohamedBassem

Base: mainHead: feat/switch-to-oxlint


📝 Commits (3)

  • aa4373e chore: migrate away from eslint to oxlint
  • 5e29775 revert turbo task name lint
  • 335b332 it seems like we can remove the seemingly default globals

📊 Changes

70 files changed (+1174 additions, -1695 deletions)

View changed files

.oxlintrc.json (+12 -0)
apps/browser-extension/.oxlintrc.json (+34 -0)
📝 apps/browser-extension/package.json (+2 -13)
apps/cli/.oxlintrc.json (+22 -0)
📝 apps/cli/package.json (+2 -9)
📝 apps/cli/src/commands/bookmarks.ts (+1 -1)
apps/landing/.oxlintrc.json (+34 -0)
📝 apps/landing/package.json (+2 -10)
apps/mcp/.oxlintrc.json (+22 -0)
📝 apps/mcp/package.json (+2 -9)
apps/mobile/.oxlintrc.json (+39 -0)
📝 apps/mobile/app/dashboard/bookmarks/new.tsx (+1 -1)
📝 apps/mobile/components/bookmarks/BookmarkCard.tsx (+1 -1)
📝 apps/mobile/package.json (+2 -18)
apps/web/.oxlintrc.json (+35 -0)
📝 apps/web/app/dashboard/cleanups/page.tsx (+1 -0)
📝 apps/web/app/dashboard/highlights/page.tsx (+1 -0)
📝 apps/web/app/dashboard/lists/page.tsx (+1 -0)
📝 apps/web/app/dashboard/tags/page.tsx (+1 -0)
📝 apps/web/components/dashboard/bookmarks/EditorCard.tsx (+1 -1)

...and 50 more files

📄 Description

Summary

closes #1614

  • migrate from eslint8 to eslint9 with eslint-configuration-migrator
  • migrate from eslint9 (flat config) to oxlint with oxlint-migrate
  • ran pnpm -r run lint and pnpm -r run format and make some necessary changes

Notes

Oh yeah, you should install the oxc extension if you want the lint error to show up in vs code

References


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1642 **Author:** [@xuatz](https://github.com/xuatz) **Created:** 6/20/2025 **Status:** ✅ Merged **Merged:** 6/22/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `feat/switch-to-oxlint` --- ### 📝 Commits (3) - [`aa4373e`](https://github.com/karakeep-app/karakeep/commit/aa4373ebc3e5eb72717ce5808b94222d22fb6c48) chore: migrate away from eslint to oxlint - [`5e29775`](https://github.com/karakeep-app/karakeep/commit/5e2977537772e5f4403a9a1248623e0a9687b3a3) revert turbo task name lint - [`335b332`](https://github.com/karakeep-app/karakeep/commit/335b332290b37b4888ab2c86881c23e88536062d) it seems like we can remove the seemingly default globals ### 📊 Changes **70 files changed** (+1174 additions, -1695 deletions) <details> <summary>View changed files</summary> ➕ `.oxlintrc.json` (+12 -0) ➕ `apps/browser-extension/.oxlintrc.json` (+34 -0) 📝 `apps/browser-extension/package.json` (+2 -13) ➕ `apps/cli/.oxlintrc.json` (+22 -0) 📝 `apps/cli/package.json` (+2 -9) 📝 `apps/cli/src/commands/bookmarks.ts` (+1 -1) ➕ `apps/landing/.oxlintrc.json` (+34 -0) 📝 `apps/landing/package.json` (+2 -10) ➕ `apps/mcp/.oxlintrc.json` (+22 -0) 📝 `apps/mcp/package.json` (+2 -9) ➕ `apps/mobile/.oxlintrc.json` (+39 -0) 📝 `apps/mobile/app/dashboard/bookmarks/new.tsx` (+1 -1) 📝 `apps/mobile/components/bookmarks/BookmarkCard.tsx` (+1 -1) 📝 `apps/mobile/package.json` (+2 -18) ➕ `apps/web/.oxlintrc.json` (+35 -0) 📝 `apps/web/app/dashboard/cleanups/page.tsx` (+1 -0) 📝 `apps/web/app/dashboard/highlights/page.tsx` (+1 -0) 📝 `apps/web/app/dashboard/lists/page.tsx` (+1 -0) 📝 `apps/web/app/dashboard/tags/page.tsx` (+1 -0) 📝 `apps/web/components/dashboard/bookmarks/EditorCard.tsx` (+1 -1) _...and 50 more files_ </details> ### 📄 Description ## Summary closes #1614 * migrate from eslint8 to eslint9 with `eslint-configuration-migrator` * migrate from eslint9 (flat config) to oxlint with `oxlint-migrate` * ran `pnpm -r run lint` and `pnpm -r run format` and make some necessary changes ## Notes Oh yeah, you should install the oxc extension if you want the lint error to show up in vs code * https://marketplace.visualstudio.com/items?itemName=oxc.oxc-vscode ### References * https://eslint.org/blog/2024/05/eslint-configuration-migrator/ * https://github.com/oxc-project/oxlint-migrate * @tanstack/eslint-plugin-query not supported yet * https://github.com/oxc-project/oxc/issues/481 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 11:59:33 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#1873
No description provided.