starred/karakeep

Fork 0

mirror of https://github.com/karakeep-app/karakeep.git synced 2026-04-25 07:56:05 +03:00

[PR #1544] [MERGED] feat: upgrade to pnpm@10.11.1 #1856

New issue

Closed

opened 2026-03-02 11:59:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1544
Author: @xuatz
Created: 6/6/2025
Status: ✅ Merged
Merged: 6/8/2025
Merged by: @MohamedBassem

Base: main ← Head: feat/upgrade-pnpm

📝 Commits (5)

d875aad feat: upgrade to pnpm@9.15.9
9dd549e extra stuff
51bb6a4 unpin mobile deps
bb0850b unpin root package.json deps too
d44a620 Merge branch 'main' into feat/upgrade-pnpm

📊 Changes

11 files changed (+8679 additions, -11545 deletions)

View changed files

📝 apps/browser-extension/package.json (+2 -2)
📝 apps/landing/package.json (+1 -1)
📝 apps/mobile/package.json (+23 -23)
📝 apps/web/package.json (+3 -3)
📝 package.json (+1 -1)
📝 packages/e2e_tests/tests/workers/crawler.test.ts (+2 -2)
📝 packages/open-api/karakeep-openapi-spec.json (+4 -1)
📝 packages/shared-react/package.json (+1 -1)
📝 packages/shared/utils/relativeDateUtils.ts (+1 -1)
📝 pnpm-lock.yaml (+8639 -11508)
📝 tooling/eslint/package.json (+2 -2)

📄 Description

Summary

upgrade key deps of apps/mobile
- e.g. expo, react-native and associated deps
upgrade to ~~latest version of~~ pnpm@9.15.9
~~revert pnpm@10 default behaviour to prevent deps lifecycle scripts frin running to the legacy behaviour where all deps scripts are allowed to run~~
sneakily included a small showcase of pnpm catalogs fe0ed8090cbe6f85128c2d083f6debb5ff780d17

Details

There is a breaking change for contributors' local environment.
Because of the lockfile changes, you must remove ALL node_modules folders (and maybe .turbo, i did it but i never confirmed if it was necessary). Otherwise the application will not work properly.

You can use the following commands for convenience:

rm -rf node_modules \
	&& pnpm -r exec rm -rf node_modules \
	&& rm -rf .turbo \
	&& pnpm -r exec rm -rf .turbo;

Or just do it yourself, don't wipe your disk!

I think that maybe, we can do v0.26.0 release that does not contain any new features, but only the pnpm upgrade?

Or perhaps include this PR for v0.25.0, but maybe give it a week or 2 in the nightly channel. Are there nightly builds for the react-native apps as well?

Notes

A proof that a certain commit had passing ci jobs at least once in the past

https://github.com/karakeep-app/karakeep/actions/runs/15496406769/job/43634748159?pr=1544

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1544 **Author:** [@xuatz](https://github.com/xuatz) **Created:** 6/6/2025 **Status:** ✅ Merged **Merged:** 6/8/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `feat/upgrade-pnpm` --- ### 📝 Commits (5) - [`d875aad`](https://github.com/karakeep-app/karakeep/commit/d875aadc91d35a720f5521ad53c67f46935eca95) feat: upgrade to pnpm@9.15.9 - [`9dd549e`](https://github.com/karakeep-app/karakeep/commit/9dd549e90d8dbf0d40b0b782a4689d743b8173df) extra stuff - [`51bb6a4`](https://github.com/karakeep-app/karakeep/commit/51bb6a497c7d20f33585e1d21d889379c93a2716) unpin mobile deps - [`bb0850b`](https://github.com/karakeep-app/karakeep/commit/bb0850b7fdae4379ad474502486cfa5987516a22) unpin root package.json deps too - [`d44a620`](https://github.com/karakeep-app/karakeep/commit/d44a62095f9f891176cfb8a662ef88524d25e591) Merge branch 'main' into feat/upgrade-pnpm ### 📊 Changes **11 files changed** (+8679 additions, -11545 deletions) <details> <summary>View changed files</summary> 📝 `apps/browser-extension/package.json` (+2 -2) 📝 `apps/landing/package.json` (+1 -1) 📝 `apps/mobile/package.json` (+23 -23) 📝 `apps/web/package.json` (+3 -3) 📝 `package.json` (+1 -1) 📝 `packages/e2e_tests/tests/workers/crawler.test.ts` (+2 -2) 📝 `packages/open-api/karakeep-openapi-spec.json` (+4 -1) 📝 `packages/shared-react/package.json` (+1 -1) 📝 `packages/shared/utils/relativeDateUtils.ts` (+1 -1) 📝 `pnpm-lock.yaml` (+8639 -11508) 📝 `tooling/eslint/package.json` (+2 -2) </details> ### 📄 Description ## Summary * upgrade key deps of apps/mobile * e.g. expo, react-native and associated deps * upgrade to ~~latest version of~~ pnpm@9.15.9 * ~~revert pnpm@10 default behaviour to prevent deps lifecycle scripts frin running to the legacy behaviour where all deps scripts are allowed to run~~ * ~~**sneakily included a small showcase of pnpm catalogs** fe0ed8090cbe6f85128c2d083f6debb5ff780d17~~ ## Details There is a breaking change for contributors' local environment. Because of the lockfile changes, you must remove ALL `node_modules` folders (and maybe .turbo, i did it but i never confirmed if it was necessary). Otherwise the application will not work properly. You can use the following commands for convenience: ```bash rm -rf node_modules \ && pnpm -r exec rm -rf node_modules \ && rm -rf .turbo \ && pnpm -r exec rm -rf .turbo; ``` Or just do it yourself, don't wipe your disk! --- I think that maybe, we can do `v0.26.0` release that does not contain any new features, but only the pnpm upgrade? Or perhaps include this PR for `v0.25.0`, but maybe give it a week or 2 in the nightly channel. Are there nightly builds for the react-native apps as well? ## Notes A proof that a certain commit had passing ci jobs at least once in the past * https://github.com/karakeep-app/karakeep/actions/runs/15496406769/job/43634748159?pr=1544 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:29 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1856

No description provided.

Rows
Columns