[PR #1515] [MERGED] feat: preserve unsaved title changes when modifying bookmark tags #1852

Closed
opened 2026-03-02 11:59:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1515
Author: @AdrianAcala
Created: 6/2/2025
Status: Merged
Merged: 6/7/2025
Merged by: @MohamedBassem

Base: mainHead: 1339-Unsaved-Title-Changes-Lost-When-Modifying-Tags


📝 Commits (2)

  • fe3b62a feat: preserve unsaved title changes when modifying bookmark tags
  • bdc4388 Revert unnecessary modifications

📊 Changes

2 files changed (+32 additions, -6 deletions)

View changed files

📝 apps/web/components/dashboard/bookmarks/EditBookmarkDialog.tsx (+5 -6)
apps/web/lib/hooks/useDialogFormReset.ts (+27 -0)

📄 Description

Prevents loss of unsaved title edits when users interact with tag selectors or other UI elements. Adds useDialogFormReset hook to maintain form state consistency across component re-renders.

Fixes #1339


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1515 **Author:** [@AdrianAcala](https://github.com/AdrianAcala) **Created:** 6/2/2025 **Status:** ✅ Merged **Merged:** 6/7/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `1339-Unsaved-Title-Changes-Lost-When-Modifying-Tags` --- ### 📝 Commits (2) - [`fe3b62a`](https://github.com/karakeep-app/karakeep/commit/fe3b62a231941fbec0db14fd22ad083128cbdaf0) feat: preserve unsaved title changes when modifying bookmark tags - [`bdc4388`](https://github.com/karakeep-app/karakeep/commit/bdc438810518e4cae33df2c9f9d1d245723a58f6) Revert unnecessary modifications ### 📊 Changes **2 files changed** (+32 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/components/dashboard/bookmarks/EditBookmarkDialog.tsx` (+5 -6) ➕ `apps/web/lib/hooks/useDialogFormReset.ts` (+27 -0) </details> ### 📄 Description Prevents loss of unsaved title edits when users interact with tag selectors or other UI elements. Adds useDialogFormReset hook to maintain form state consistency across component re-renders. Fixes #1339 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 11:59:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#1852
No description provided.