[PR #1493] [CLOSED] feat: Add text highlighting to note bookmarks #1843

New issue

Closed

opened 2026-03-02 11:59:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1493
Author: @AdrianAcala
Created: 5/29/2025
Status: ❌ Closed

Base: main ← Head: feature/note-text-highlighting-1342

📝 Commits (1)

f93a565 feat: Add text highlighting to note bookmarks

📊 Changes

6 files changed (+902 additions, -10 deletions)

View changed files

📝 apps/web/app/layout.tsx (+3 -2)
➕ apps/web/components/dashboard/preview/BookmarkTextHighlighter.tsx (+406 -0)
📝 apps/web/components/dashboard/preview/HighlightsBox.tsx (+4 -3)
📝 apps/web/components/dashboard/preview/TextContentSection.tsx (+81 -5)
➕ packages/e2e_tests/tests/api/text-highlights.test.ts (+342 -0)
📝 packages/trpc/routers/highlights.test.ts (+66 -0)

📄 Description

Allow users to highlight text within note bookmarks, extending the existing highlighting functionality to markdown content. Users can now select text in notes and apply colored highlights (yellow, red, green, blue) with the same interface used for link content.

This feature addresses the need to emphasize specific parts of copied text from sources like ChatGPT or Claude, improving the research note-taking experience by making content more navigable and emphasizable.

The implementation reuses the existing highlight database schema and tRPC routes, ensuring consistency with link highlighting while adding comprehensive test coverage for text-specific scenarios including unicode characters, overlapping highlights, and edge cases.

Fixes #1342

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1493 **Author:** [@AdrianAcala](https://github.com/AdrianAcala) **Created:** 5/29/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature/note-text-highlighting-1342` --- ### 📝 Commits (1) - [`f93a565`](https://github.com/karakeep-app/karakeep/commit/f93a5654e540ef4e27bdd64d187698c824cc2520) feat: Add text highlighting to note bookmarks ### 📊 Changes **6 files changed** (+902 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/app/layout.tsx` (+3 -2) ➕ `apps/web/components/dashboard/preview/BookmarkTextHighlighter.tsx` (+406 -0) 📝 `apps/web/components/dashboard/preview/HighlightsBox.tsx` (+4 -3) 📝 `apps/web/components/dashboard/preview/TextContentSection.tsx` (+81 -5) ➕ `packages/e2e_tests/tests/api/text-highlights.test.ts` (+342 -0) 📝 `packages/trpc/routers/highlights.test.ts` (+66 -0) </details> ### 📄 Description Allow users to highlight text within note bookmarks, extending the existing highlighting functionality to markdown content. Users can now select text in notes and apply colored highlights (yellow, red, green, blue) with the same interface used for link content. This feature addresses the need to emphasize specific parts of copied text from sources like ChatGPT or Claude, improving the research note-taking experience by making content more navigable and emphasizable. The implementation reuses the existing highlight database schema and tRPC routes, ensuring consistency with link highlighting while adding comprehensive test coverage for text-specific scenarios including unicode characters, overlapping highlights, and edge cases. Fixes #1342 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:25 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1843

No description provided.

Rows
Columns