[PR #1492] [CLOSED] fix: Browser extension tab tracking and tags page performance #1842

New issue

Closed

opened 2026-03-02 11:59:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1492
Author: @AdrianAcala
Created: 5/29/2025
Status: ❌ Closed

Base: main ← Head: fix-browser-extension-tab-tracking

📝 Commits (1)

5d9eb8f fix: Browser extension tab tracking and tags page performance

📊 Changes

17 files changed (+371 additions, -55 deletions)

View changed files

📝 apps/browser-extension/src/SavePage.tsx (+1 -1)
📝 apps/browser-extension/src/components/ui/dialog.tsx (+2 -2)
📝 apps/browser-extension/src/components/ui/popover.tsx (+1 -1)
📝 apps/web/app/dashboard/tags/page.tsx (+1 -1)
📝 apps/web/components/dashboard/cleanups/TagDuplicationDetention.tsx (+3 -3)
📝 apps/web/components/dashboard/highlights/HighlightCard.tsx (+1 -1)
📝 apps/web/components/dashboard/preview/LinkContentSection.tsx (+1 -1)
📝 apps/web/components/dashboard/tags/AllTagsView.tsx (+57 -33)
📝 apps/web/components/ui/dialog.tsx (+2 -2)
📝 apps/web/components/ui/dropdown-menu.tsx (+2 -2)
📝 apps/web/components/ui/markdown/markdown-editor.tsx (+1 -1)
📝 apps/web/components/ui/popover.tsx (+1 -1)
📝 apps/web/components/ui/select.tsx (+1 -1)
📝 apps/web/components/ui/toast.tsx (+1 -1)
📝 apps/web/components/ui/tooltip.tsx (+1 -1)
➕ packages/trpc/routers/tags.pagination.test.ts (+264 -0)
📝 packages/trpc/routers/tags.ts (+31 -3)

📄 Description

Fix browser extension tab tracking by using currentWindow instead of lastFocusedWindow
- Resolves issue where extension would track incorrect tab when popup was opened
- Fixes issue #111 comment
Optimize tags page performance for large tag collections
- Add pagination support to tags.list API endpoint (limit/offset)
- Limit initial tag load to 100 tags to improve page load time
- Add search functionality to filter tags on client side
- Add test coverage
- Fixes #1404

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1492 **Author:** [@AdrianAcala](https://github.com/AdrianAcala) **Created:** 5/29/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-browser-extension-tab-tracking` --- ### 📝 Commits (1) - [`5d9eb8f`](https://github.com/karakeep-app/karakeep/commit/5d9eb8f150ba7bff9f3c016164b63b4aa5509620) fix: Browser extension tab tracking and tags page performance ### 📊 Changes **17 files changed** (+371 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `apps/browser-extension/src/SavePage.tsx` (+1 -1) 📝 `apps/browser-extension/src/components/ui/dialog.tsx` (+2 -2) 📝 `apps/browser-extension/src/components/ui/popover.tsx` (+1 -1) 📝 `apps/web/app/dashboard/tags/page.tsx` (+1 -1) 📝 `apps/web/components/dashboard/cleanups/TagDuplicationDetention.tsx` (+3 -3) 📝 `apps/web/components/dashboard/highlights/HighlightCard.tsx` (+1 -1) 📝 `apps/web/components/dashboard/preview/LinkContentSection.tsx` (+1 -1) 📝 `apps/web/components/dashboard/tags/AllTagsView.tsx` (+57 -33) 📝 `apps/web/components/ui/dialog.tsx` (+2 -2) 📝 `apps/web/components/ui/dropdown-menu.tsx` (+2 -2) 📝 `apps/web/components/ui/markdown/markdown-editor.tsx` (+1 -1) 📝 `apps/web/components/ui/popover.tsx` (+1 -1) 📝 `apps/web/components/ui/select.tsx` (+1 -1) 📝 `apps/web/components/ui/toast.tsx` (+1 -1) 📝 `apps/web/components/ui/tooltip.tsx` (+1 -1) ➕ `packages/trpc/routers/tags.pagination.test.ts` (+264 -0) 📝 `packages/trpc/routers/tags.ts` (+31 -3) </details> ### 📄 Description - Fix browser extension tab tracking by using currentWindow instead of lastFocusedWindow - Resolves issue where extension would track incorrect tab when popup was opened - Fixes issue #111 comment - Optimize tags page performance for large tag collections - Add pagination support to tags.list API endpoint (limit/offset) - Limit initial tag load to 100 tags to improve page load time - Add search functionality to filter tags on client side - Add test coverage - Fixes #1404 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:25 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1842

No description provided.

Rows
Columns