[PR #1474] [MERGED] feat: add optional `thinking` key to tagging response schema + other prompt enhancements #1833

New issue

Closed

opened 2026-03-02 11:59:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1474
Author: @thiswillbeyourgithub
Created: 5/26/2025
Status: ✅ Merged
Merged: 6/22/2025
Merged by: @MohamedBassem

Base: main ← Head: feat_thinking_tags

📝 Commits (10+)

fceafdd feat: add optional thinking key to tagging response schema
98e10a7 prompt: fix indent
98c2e8f prompt: remove extra 'language' word
5ffdb47 prompt: use xml as separator
9d58139 revert: dont use a thinking tags
e21a073 prompt: don't ask to include website tags
50d58f7 prompt: aim for 5 tags
150c919 prompt: dont tell bot its a bot
f2ccf3f prompt: propose a tag_error
2e04573 Revert "prompt: propose a tag_error"

📊 Changes

1 file changed (+11 additions, -10 deletions)

View changed files

📝 packages/shared/prompts.ts (+11 -10)

📄 Description

In my experience this helps all (both thinking and non thinking) models to provide better answers. I have not seen any negative side effects from that commit so far.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1474 **Author:** [@thiswillbeyourgithub](https://github.com/thiswillbeyourgithub) **Created:** 5/26/2025 **Status:** ✅ Merged **Merged:** 6/22/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `feat_thinking_tags` --- ### 📝 Commits (10+) - [`fceafdd`](https://github.com/karakeep-app/karakeep/commit/fceafdd4f445af1bc14ccd2b08b1d1a099ff7a9b) feat: add optional `thinking` key to tagging response schema - [`98e10a7`](https://github.com/karakeep-app/karakeep/commit/98e10a77d49dff36bca6769ab9f3333a43b5919d) prompt: fix indent - [`98c2e8f`](https://github.com/karakeep-app/karakeep/commit/98c2e8f8b0ccc6dc12bbf92d5f1035c5773adb86) prompt: remove extra 'language' word - [`5ffdb47`](https://github.com/karakeep-app/karakeep/commit/5ffdb470763eeaa2569ad125edfe845a56507edf) prompt: use xml as separator - [`9d58139`](https://github.com/karakeep-app/karakeep/commit/9d58139afb1bae8b4db61388da65976cbebab1ce) revert: dont use a thinking tags - [`e21a073`](https://github.com/karakeep-app/karakeep/commit/e21a07343550b48aad2fdf59a638c787fb6898e3) prompt: don't ask to include website tags - [`50d58f7`](https://github.com/karakeep-app/karakeep/commit/50d58f743ea56e4276d1ee512ec516e00301545a) prompt: aim for 5 tags - [`150c919`](https://github.com/karakeep-app/karakeep/commit/150c919cab79e9b4a230be1e7b2797af3278e11b) prompt: dont tell bot its a bot - [`f2ccf3f`](https://github.com/karakeep-app/karakeep/commit/f2ccf3f9be9a0572726f8b1c92c547afae3a85a0) prompt: propose a tag_error - [`2e04573`](https://github.com/karakeep-app/karakeep/commit/2e0457380ec04030de8214fa4825b1db6360e4fc) Revert "prompt: propose a tag_error" ### 📊 Changes **1 file changed** (+11 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/shared/prompts.ts` (+11 -10) </details> ### 📄 Description In my experience this helps all (both thinking and non thinking) models to provide better answers. I have not seen any negative side effects from that commit so far. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:23 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1833

No description provided.

Rows
Columns

[PR #1474] [MERGED] feat: add optional thinking key to tagging response schema + other prompt enhancements #1833

📋 Pull Request Information

📝 Commits (10+)

📊 Changes

📄 Description

[PR #1474] [MERGED] feat: add optional `thinking` key to tagging response schema + other prompt enhancements #1833