[PR #1443] [CLOSED] fix: Improve videoWorker error handling and use data directory for do… #1824

New issue

Closed

opened 2026-03-02 11:59:21 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1443
Author: @erik-nilcoast
Created: 5/20/2025
Status: ❌ Closed

Base: main ← Head: erik/fix-ytdlp

📝 Commits (1)

dec6eb6 fix(worker): fixes issues with storing videos in /tmp or a specified directory

📊 Changes

2 files changed (+24 additions, -7 deletions)

View changed files

📝 apps/workers/workers/videoWorker.ts (+19 -2)
📝 docs/docs/03-configuration.md (+5 -5)

📄 Description

This PR makes a few improvements to the videoWorker (it now works locally quite well).

fix: Correct string template interpolation in error logging (use backticks)
improve: Make videoWorker use the configured dataDir for video downloads when available
fix: Add proper null checking in UpdatableBookmarksGrid to prevent potential errors

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1443 **Author:** [@erik-nilcoast](https://github.com/erik-nilcoast) **Created:** 5/20/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `erik/fix-ytdlp` --- ### 📝 Commits (1) - [`dec6eb6`](https://github.com/karakeep-app/karakeep/commit/dec6eb6f87339c7cb70175c038339cabc235c77e) fix(worker): fixes issues with storing videos in /tmp or a specified directory ### 📊 Changes **2 files changed** (+24 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `apps/workers/workers/videoWorker.ts` (+19 -2) 📝 `docs/docs/03-configuration.md` (+5 -5) </details> ### 📄 Description This PR makes a few improvements to the videoWorker (it now works locally quite well). - **fix:** Correct string template interpolation in error logging (use backticks) - **improve:** Make videoWorker use the configured dataDir for video downloads when available - **fix:** Add proper null checking in UpdatableBookmarksGrid to prevent potential errors --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:21 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1824

No description provided.

Rows
Columns