[PR #1398] [MERGED] feat(api): enable ?sortOrder= for relevant resources #1814

New issue

Closed

opened 2026-03-02 11:59:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1398
Author: @xuatz
Created: 5/12/2025
Status: ✅ Merged
Merged: 5/18/2025
Merged by: @MohamedBassem

Base: main ← Head: feat/update-api-sortorder-docs

📝 Commits (2)

800865c feat(api): enable ?sortOrder= for relevant resources
b62305a fix tests

📊 Changes

14 files changed (+126 additions, -34 deletions)

View changed files

📝 .prettierignore (+1 -0)
📝 apps/web/app/api/v1/bookmarks/[bookmarkId]/route.ts (+2 -2)
📝 apps/web/app/api/v1/bookmarks/route.ts (+8 -1)
📝 apps/web/app/api/v1/bookmarks/search/route.ts (+1 -0)
📝 apps/web/app/api/v1/lists/[listId]/bookmarks/route.ts (+2 -2)
📝 apps/web/app/api/v1/tags/[tagId]/bookmarks/route.ts (+3 -2)
📝 apps/web/app/api/v1/utils/types.ts (+12 -0)
📝 packages/open-api/karakeep-openapi-spec.json (+57 -4)
📝 packages/open-api/lib/bookmarks.ts (+6 -0)
📝 packages/open-api/lib/lists.ts (+12 -3)
📝 packages/open-api/lib/tags.ts (+12 -3)
📝 packages/open-api/package.json (+1 -0)
📝 packages/open-api/tsconfig.json (+1 -1)
📝 packages/sdk/src/karakeep-api.d.ts (+8 -16)

📄 Description

Summary

Addresses the comment by @thiswillbeyourgithub
- https://github.com/karakeep-app/karakeep/pull/1392#issuecomment-2870028422
added/verified sortOrder functionality in the api for relevant resources
update open-api docs

Notes

Technically this should be merged after #1392

Btw I'm not sure how much CI magic has been setup and if there are more docs or tasks that I also need to update for this PR, so please let me know if I missed anything.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1398 **Author:** [@xuatz](https://github.com/xuatz) **Created:** 5/12/2025 **Status:** ✅ Merged **Merged:** 5/18/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `feat/update-api-sortorder-docs` --- ### 📝 Commits (2) - [`800865c`](https://github.com/karakeep-app/karakeep/commit/800865cce51ae943c1cfa77cf826bb40efeb6e71) feat(api): enable `?sortOrder=` for relevant resources - [`b62305a`](https://github.com/karakeep-app/karakeep/commit/b62305a12dfc9590a918855f3b4c418cc66b228b) fix tests ### 📊 Changes **14 files changed** (+126 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `.prettierignore` (+1 -0) 📝 `apps/web/app/api/v1/bookmarks/[bookmarkId]/route.ts` (+2 -2) 📝 `apps/web/app/api/v1/bookmarks/route.ts` (+8 -1) 📝 `apps/web/app/api/v1/bookmarks/search/route.ts` (+1 -0) 📝 `apps/web/app/api/v1/lists/[listId]/bookmarks/route.ts` (+2 -2) 📝 `apps/web/app/api/v1/tags/[tagId]/bookmarks/route.ts` (+3 -2) 📝 `apps/web/app/api/v1/utils/types.ts` (+12 -0) 📝 `packages/open-api/karakeep-openapi-spec.json` (+57 -4) 📝 `packages/open-api/lib/bookmarks.ts` (+6 -0) 📝 `packages/open-api/lib/lists.ts` (+12 -3) 📝 `packages/open-api/lib/tags.ts` (+12 -3) 📝 `packages/open-api/package.json` (+1 -0) 📝 `packages/open-api/tsconfig.json` (+1 -1) 📝 `packages/sdk/src/karakeep-api.d.ts` (+8 -16) </details> ### 📄 Description ## Summary * Addresses the comment by @thiswillbeyourgithub * https://github.com/karakeep-app/karakeep/pull/1392#issuecomment-2870028422 * added/verified `sortOrder` functionality in the api for relevant resources * update open-api docs ## Notes Technically this should be merged after #1392 Btw I'm not sure how much CI magic has been setup and if there are more docs or tasks that I also need to update for this PR, so please let me know if I missed anything. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:18 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1814

No description provided.

Rows
Columns