[PR #1327] [MERGED] Feature: Add US English as option in User Settings #1799

New issue

Closed

opened 2026-03-02 11:59:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1327
Author: @WilliamAGH
Created: 4/28/2025
Status: ✅ Merged
Merged: 5/10/2025
Merged by: @MohamedBassem

Base: main ← Head: improv-us-english

📝 Commits (2)

f4f4a83 improvement: tweak American English
22e93c0 feat: add en_us language to user settings list

📊 Changes

2 files changed (+20 additions, -19 deletions)

View changed files

📝 apps/web/lib/i18n/locales/en_US/translation.json (+19 -19)
📝 packages/shared/langs.ts (+1 -0)

📄 Description

This pull request focuses on improving language consistency in user-facing text and adding support for a new language variant. The changes include updates to English (US) translations for better grammar and tone, and the addition of en_US to the language mappings.

Language Consistency Improvements:

Updated several strings in apps/web/lib/i18n/locales/en_US/translation.json to use consistent capitalization and tone, such as changing "Import as Text Bookmark" to "Import as text bookmark" and "No rules created yet, dude" to "No rules have been created yet" [1] [2] [3] [4] [5].

Language Support:

Added en_US as a new language variant in the langNameMappings object in packages/shared/langs.ts.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1327 **Author:** [@WilliamAGH](https://github.com/WilliamAGH) **Created:** 4/28/2025 **Status:** ✅ Merged **Merged:** 5/10/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `improv-us-english` --- ### 📝 Commits (2) - [`f4f4a83`](https://github.com/karakeep-app/karakeep/commit/f4f4a830e40c19c8d4f9752b395877b8aaecbc17) improvement: tweak American English - [`22e93c0`](https://github.com/karakeep-app/karakeep/commit/22e93c07e8a1f08cc76335dcdb52a9a5e045752a) feat: add en_us language to user settings list ### 📊 Changes **2 files changed** (+20 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/lib/i18n/locales/en_US/translation.json` (+19 -19) 📝 `packages/shared/langs.ts` (+1 -0) </details> ### 📄 Description This pull request focuses on improving language consistency in user-facing text and adding support for a new language variant. The changes include updates to English (US) translations for better grammar and tone, and the addition of `en_US` to the language mappings. ### Language Consistency Improvements: * Updated several strings in `apps/web/lib/i18n/locales/en_US/translation.json` to use consistent capitalization and tone, such as changing "Import as Text Bookmark" to "Import as text bookmark" and "No rules created yet, dude" to "No rules have been created yet" [[1]](diffhunk://#diff-1a4cddfab06d3ca6379b7f7fde5caeff84782ab02de2d6f8523fe827c82bb223L152-R155) [[2]](diffhunk://#diff-1a4cddfab06d3ca6379b7f7fde5caeff84782ab02de2d6f8523fe827c82bb223L269-R269) [[3]](diffhunk://#diff-1a4cddfab06d3ca6379b7f7fde5caeff84782ab02de2d6f8523fe827c82bb223L384-R384) [[4]](diffhunk://#diff-1a4cddfab06d3ca6379b7f7fde5caeff84782ab02de2d6f8523fe827c82bb223L393-R403) [[5]](diffhunk://#diff-1a4cddfab06d3ca6379b7f7fde5caeff84782ab02de2d6f8523fe827c82bb223L414-R425). ### Language Support: * Added `en_US` as a new language variant in the `langNameMappings` object in `packages/shared/langs.ts`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:14 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1799

No description provided.

Rows
Columns