[PR #1283] [CLOSED] Fix icon visibility in dark mode for Firefox extension #1787

New issue

Closed

opened 2026-03-02 11:59:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1283
Author: @AdrianAcala
Created: 4/20/2025
Status: ❌ Closed

Base: main ← Head: 1282-fix-icon-issue

📝 Commits (1)

a8bd416 Fix icon visibility in dark mode for Firefox extension

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 apps/browser-extension/manifest.json (+6 -6)

📄 Description

This fixes #1282. Seemed like it was just a simple error mixing up light mode and dark mode images. I replicated the issue in my browser and then made the fix and it came up fine.

I did have some linting issues but I ignored them as I didn't want to include linting errors I didn't touch in the fix.

This is the current version:

This is the version with the fix:

If you want me to include the linting fixes in this PR, just let me know and I'll put them in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1283 **Author:** [@AdrianAcala](https://github.com/AdrianAcala) **Created:** 4/20/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `1282-fix-icon-issue` --- ### 📝 Commits (1) - [`a8bd416`](https://github.com/karakeep-app/karakeep/commit/a8bd416c8b916b6b5f505f4411c4f46b347bfafe) Fix icon visibility in dark mode for Firefox extension ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `apps/browser-extension/manifest.json` (+6 -6) </details> ### 📄 Description This fixes #1282. Seemed like it was just a simple error mixing up light mode and dark mode images. I replicated the issue in my browser and then made the fix and it came up fine. I did have some linting issues but I ignored them as I didn't want to include linting errors I didn't touch in the fix. This is the current version: ![Current version](https://github.com/user-attachments/assets/d5736a87-0ca1-4f43-ad63-3f5a4b941f18) This is the version with the fix: ![Fixed version](https://github.com/user-attachments/assets/46bf1ef9-f734-42fe-aadd-39b305f420bc) If you want me to include the linting fixes in this PR, just let me know and I'll put them in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:10 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-02 11:59:44 +03:00

[PR #1870] [MERGED] feat: Show loading indicator while export file is being generated #1787 #1914

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1787

No description provided.

Rows
Columns