[PR #1155] [MERGED] Add CRAWLER_SCREENSHOT_TIMEOUT_SEC settings #1746

Closed
opened 2026-03-02 11:58:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1155
Author: @Summon528
Created: 3/23/2025
Status: Merged
Merged: 3/27/2025
Merged by: @MohamedBassem

Base: mainHead: screenshot-timeout


📝 Commits (1)

  • 68218a1 Add CRAWLER_SCREENSHOT_TIMEOUT_SEC

📊 Changes

3 files changed (+21 additions, -10 deletions)

View changed files

📝 apps/workers/crawlerWorker.ts (+18 -10)
📝 docs/docs/03-configuration.md (+1 -0)
📝 packages/shared/config.ts (+2 -0)

📄 Description

Should fix #1097

Add a setting to change the default screenshot timeout, since capturing a full-page screenshot of a long webpage would easily exceed the current hard-coded limit.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1155 **Author:** [@Summon528](https://github.com/Summon528) **Created:** 3/23/2025 **Status:** ✅ Merged **Merged:** 3/27/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `screenshot-timeout` --- ### 📝 Commits (1) - [`68218a1`](https://github.com/karakeep-app/karakeep/commit/68218a18172e2690a7d91262a71a19abf18b001c) Add CRAWLER_SCREENSHOT_TIMEOUT_SEC ### 📊 Changes **3 files changed** (+21 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `apps/workers/crawlerWorker.ts` (+18 -10) 📝 `docs/docs/03-configuration.md` (+1 -0) 📝 `packages/shared/config.ts` (+2 -0) </details> ### 📄 Description Should fix #1097 Add a setting to change the default screenshot timeout, since capturing a full-page screenshot of a long webpage would easily exceed the current hard-coded limit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 11:58:59 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#1746
No description provided.