[PR #1151] [MERGED] Close browser if connect on demand #1744

New issue

Closed

opened 2026-03-02 11:58:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:58:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1151
Author: @Summon528
Created: 3/23/2025
Status: ✅ Merged
Merged: 4/16/2025
Merged by: @MohamedBassem

Base: main ← Head: patch1

📝 Commits (1)

bce7a79 Close browser if connect on demand

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 apps/workers/crawlerWorker.ts (+3 -0)

📄 Description

Fix https://github.com/hoarder-app/hoarder/discussions/869

Close the browser instance after crawling if browserConnectOnDemand is enabled.
This should help users that are using service like browserless to reduce API usage.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1151 **Author:** [@Summon528](https://github.com/Summon528) **Created:** 3/23/2025 **Status:** ✅ Merged **Merged:** 4/16/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `patch1` --- ### 📝 Commits (1) - [`bce7a79`](https://github.com/karakeep-app/karakeep/commit/bce7a796d697b3e57b18dea4d0d5e336850e4e69) Close browser if connect on demand ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `apps/workers/crawlerWorker.ts` (+3 -0) </details> ### 📄 Description Fix https://github.com/hoarder-app/hoarder/discussions/869 Close the browser instance after crawling if browserConnectOnDemand is enabled. This should help users that are using service like browserless to reduce API usage. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:58:59 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1744

No description provided.

Rows
Columns