[PR #715] [MERGED] #701 Improve note support : WYSIWYG markdown #1683

New issue

Closed

opened 2026-03-02 11:58:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:58:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/715
Author: @Tukks
Created: 12/3/2024
Status: ✅ Merged
Merged: 12/21/2024
Merged by: @MohamedBassem

Base: main ← Head: feat/fulle-featured-markdown-editor

📝 Commits (10+)

19f0427 #701 Improve note support : WYSIWYG markdown
e3bc06d #701 Improve note support : WYSIWYG markdown
21534f3 Use markdown shortcuts
df3d849 Remove the alignment actions
85678d4 Drop history buttons
8926635 Fix code and highlighting buttons
e130d96 Remove the unneeded update markdown plugin
eae4e15 Remove underline support as it's not markdown native
c5894ba - added ListPlugin because if absent, there's a bug where you can't escape a list with enter + enter
deb4dfe delete theme.ts

📊 Changes

14 files changed (+1177 additions, -129 deletions)

View changed files

➕ apps/web/components/dashboard/bookmarks/BookmarkMarkdownComponent.tsx (+43 -0)
📝 apps/web/components/dashboard/bookmarks/BookmarkedTextEditor.tsx (+12 -55)
📝 apps/web/components/dashboard/bookmarks/TextCard.tsx (+6 -5)
📝 apps/web/components/dashboard/preview/TextContentSection.tsx (+5 -2)
➕ apps/web/components/ui/markdown/markdown-editor.tsx (+124 -0)
📝 apps/web/components/ui/markdown/markdown-readonly.tsx (+57 -61)
➕ apps/web/components/ui/markdown/plugins/toolbar-plugin.tsx (+290 -0)
➕ apps/web/components/ui/markdown/theme.ts (+35 -0)
➕ apps/web/components/ui/switch.tsx (+28 -0)
📝 apps/web/lib/i18n/locales/de/translation.json (+14 -1)
📝 apps/web/lib/i18n/locales/en/translation.json (+49 -1)
📝 apps/web/lib/i18n/locales/fr/translation.json (+14 -1)
📝 apps/web/package.json (+7 -0)
📝 pnpm-lock.yaml (+493 -3)

📄 Description

First implementation with a wysiwyg markdown editor. Update:

Add Lexical markdown editor
consistent rendering between card and preview
removed edit modal, replaced by preview with save action
simple markdown shortcut: underline, bold, italic etc...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/715 **Author:** [@Tukks](https://github.com/Tukks) **Created:** 12/3/2024 **Status:** ✅ Merged **Merged:** 12/21/2024 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `feat/fulle-featured-markdown-editor` --- ### 📝 Commits (10+) - [`19f0427`](https://github.com/karakeep-app/karakeep/commit/19f0427552d07ed683e21d27cfad9825188ef8f2) #701 Improve note support : WYSIWYG markdown - [`e3bc06d`](https://github.com/karakeep-app/karakeep/commit/e3bc06db025032cbe51722cf8f2756f374ae87d9) #701 Improve note support : WYSIWYG markdown - [`21534f3`](https://github.com/karakeep-app/karakeep/commit/21534f39867d29850180a3920ece04c04307c870) Use markdown shortcuts - [`df3d849`](https://github.com/karakeep-app/karakeep/commit/df3d84923e5ef34b54ebb0cd903bdbc2f1c3b871) Remove the alignment actions - [`85678d4`](https://github.com/karakeep-app/karakeep/commit/85678d48c01b98ef83d97b40162128f4c0171ff6) Drop history buttons - [`8926635`](https://github.com/karakeep-app/karakeep/commit/8926635806658cc41ff2c0a5e8e84fd3f3aa9db8) Fix code and highlighting buttons - [`e130d96`](https://github.com/karakeep-app/karakeep/commit/e130d96005a84bf51d6c29a066171e31c3aca407) Remove the unneeded update markdown plugin - [`eae4e15`](https://github.com/karakeep-app/karakeep/commit/eae4e1562632e114a7569f5cb8f1af5a902c89a5) Remove underline support as it's not markdown native - [`c5894ba`](https://github.com/karakeep-app/karakeep/commit/c5894ba0baba2eb1ccbb71633f19f1fdfc6c6021) - added ListPlugin because if absent, there's a bug where you can't escape a list with enter + enter - [`deb4dfe`](https://github.com/karakeep-app/karakeep/commit/deb4dfe357afd54bbb6b9bb420373814741c873d) delete theme.ts ### 📊 Changes **14 files changed** (+1177 additions, -129 deletions) <details> <summary>View changed files</summary> ➕ `apps/web/components/dashboard/bookmarks/BookmarkMarkdownComponent.tsx` (+43 -0) 📝 `apps/web/components/dashboard/bookmarks/BookmarkedTextEditor.tsx` (+12 -55) 📝 `apps/web/components/dashboard/bookmarks/TextCard.tsx` (+6 -5) 📝 `apps/web/components/dashboard/preview/TextContentSection.tsx` (+5 -2) ➕ `apps/web/components/ui/markdown/markdown-editor.tsx` (+124 -0) 📝 `apps/web/components/ui/markdown/markdown-readonly.tsx` (+57 -61) ➕ `apps/web/components/ui/markdown/plugins/toolbar-plugin.tsx` (+290 -0) ➕ `apps/web/components/ui/markdown/theme.ts` (+35 -0) ➕ `apps/web/components/ui/switch.tsx` (+28 -0) 📝 `apps/web/lib/i18n/locales/de/translation.json` (+14 -1) 📝 `apps/web/lib/i18n/locales/en/translation.json` (+49 -1) 📝 `apps/web/lib/i18n/locales/fr/translation.json` (+14 -1) 📝 `apps/web/package.json` (+7 -0) 📝 `pnpm-lock.yaml` (+493 -3) </details> ### 📄 Description First implementation with a wysiwyg markdown editor. Update: - Add Lexical markdown editor - consistent rendering between card and preview - removed edit modal, replaced by preview with save action - simple markdown shortcut: underline, bold, italic etc... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:58:42 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1683

No description provided.

Rows
Columns