[PR #562] [CLOSED] Add share to PWA #1653

Closed
opened 2026-03-02 11:58:34 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/562
Author: @wiinxt
Created: 10/17/2024
Status: Closed

Base: mainHead: add-share-to-pwa


📝 Commits (3)

  • 599aab1 refactor(web): Refacto /api/assets route to handle multiple file uploads
  • db35f89 feat(web): Add a route for creating bookmarks via manifest share target for PWA
  • 66964ff feat(web): Add ErrorToast component for displaying error messages

📊 Changes

9 files changed (+208 additions, -69 deletions)

View changed files

📝 apps/mobile/lib/upload.ts (+5 -4)
📝 apps/web/app/api/assets/route.ts (+58 -43)
apps/web/app/api/bookmarks/create/route.tsx (+66 -0)
📝 apps/web/app/layout.tsx (+2 -0)
apps/web/components/dashboard/ErrorToast.tsx (+25 -0)
📝 apps/web/components/dashboard/UploadDropzone.tsx (+7 -3)
📝 apps/web/components/dashboard/preview/AttachmentBox.tsx (+16 -12)
📝 apps/web/public/manifest.json (+21 -1)
📝 packages/shared/types/uploads.ts (+8 -6)

📄 Description

Adds PWA in sharing options for images and PDF files, as well as sharing selected text.
I know a native app exists but I prefer the PWA, so I'm adding a button for upload files (in another pull request) and the share option because it was missing.

Hoarder is the PWA version


I'm not sure if this is the best possible implementation as I'm not really familiar with Next, I'm open to your comments


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/562 **Author:** [@wiinxt](https://github.com/wiinxt) **Created:** 10/17/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `add-share-to-pwa` --- ### 📝 Commits (3) - [`599aab1`](https://github.com/karakeep-app/karakeep/commit/599aab128b903f8e1f1e60b677e3ead1aa1ef513) refactor(web): Refacto /api/assets route to handle multiple file uploads - [`db35f89`](https://github.com/karakeep-app/karakeep/commit/db35f893f69bb15799096e1f32fb80ef4a87d963) feat(web): Add a route for creating bookmarks via manifest share target for PWA - [`66964ff`](https://github.com/karakeep-app/karakeep/commit/66964ffbd907d82fac93318be31d4a12b3134b7e) feat(web): Add ErrorToast component for displaying error messages ### 📊 Changes **9 files changed** (+208 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `apps/mobile/lib/upload.ts` (+5 -4) 📝 `apps/web/app/api/assets/route.ts` (+58 -43) ➕ `apps/web/app/api/bookmarks/create/route.tsx` (+66 -0) 📝 `apps/web/app/layout.tsx` (+2 -0) ➕ `apps/web/components/dashboard/ErrorToast.tsx` (+25 -0) 📝 `apps/web/components/dashboard/UploadDropzone.tsx` (+7 -3) 📝 `apps/web/components/dashboard/preview/AttachmentBox.tsx` (+16 -12) 📝 `apps/web/public/manifest.json` (+21 -1) 📝 `packages/shared/types/uploads.ts` (+8 -6) </details> ### 📄 Description Adds PWA in sharing options for images and PDF files, as well as sharing selected text. I know a native app exists but I prefer the PWA, so I'm adding a button for upload files (in [another pull request](https://github.com/hoarder-app/hoarder/pull/561)) and the share option because it was missing. <img src="https://github.com/user-attachments/assets/83ffaa84-1c75-4fa4-9268-fb2150d8cc5b" width="50%" _height="100"> Hoarder is the PWA version --- I'm not sure if this is the best possible implementation as I'm not really familiar with Next, I'm open to your comments --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 11:58:34 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#1653
No description provided.