[PR #526] [CLOSED] Performance #517 #1644

Closed
opened 2026-03-02 11:58:33 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/526
Author: @kamtschatka
Created: 10/12/2024
Status: Closed

Base: mainHead: fixed-loaded-image-size


📝 Commits (2)

  • e93a20e Performance #517
  • c337fb1 added cropping of preview images to a max height of 1000pixels to reduce the filesize significantly if the preview is a full page screenshot

📊 Changes

4 files changed (+43 additions, -9 deletions)

View changed files

📝 apps/web/app/api/assets/[assetId]/route.ts (+25 -2)
📝 apps/web/components/dashboard/bookmarks/LinkCard.tsx (+4 -2)
📝 packages/shared-react/utils/assetUtils.ts (+2 -2)
📝 packages/shared-react/utils/bookmarkUtils.ts (+12 -3)

📄 Description

made sure the image size is based on the bookmark containers width and not on the full page width


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/526 **Author:** [@kamtschatka](https://github.com/kamtschatka) **Created:** 10/12/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fixed-loaded-image-size` --- ### 📝 Commits (2) - [`e93a20e`](https://github.com/karakeep-app/karakeep/commit/e93a20e3dbb19971e57fb0d9d8718a9e4d873496) Performance #517 - [`c337fb1`](https://github.com/karakeep-app/karakeep/commit/c337fb1449213a3f97f453ae49ac56654d0667a1) added cropping of preview images to a max height of 1000pixels to reduce the filesize significantly if the preview is a full page screenshot ### 📊 Changes **4 files changed** (+43 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/app/api/assets/[assetId]/route.ts` (+25 -2) 📝 `apps/web/components/dashboard/bookmarks/LinkCard.tsx` (+4 -2) 📝 `packages/shared-react/utils/assetUtils.ts` (+2 -2) 📝 `packages/shared-react/utils/bookmarkUtils.ts` (+12 -3) </details> ### 📄 Description made sure the image size is based on the bookmark containers width and not on the full page width --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 11:58:33 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#1644
No description provided.