[PR #428] [MERGED] [Bug Report] Importing bookmarks adds all tags to all bookmarks #421 #1620

Closed
opened 2026-03-02 11:58:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/428
Author: @kamtschatka
Created: 9/25/2024
Status: Merged
Merged: 9/26/2024
Merged by: @MohamedBassem

Base: mainHead: bookmark-import-tag-duplication


📝 Commits (2)

  • b21f2f7 [Bug Report] Importing bookmarks adds all tags to all bookmarks #421
  • bab891f Add validation on the input of update tags to ensure that its not empty

📊 Changes

2 files changed (+39 additions, -10 deletions)

View changed files

📝 packages/trpc/routers/bookmarks.test.ts (+15 -0)
📝 packages/trpc/routers/bookmarks.ts (+24 -10)

📄 Description

fixed an issue that caused all existing tags to be assigned to a new bookmark


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/428 **Author:** [@kamtschatka](https://github.com/kamtschatka) **Created:** 9/25/2024 **Status:** ✅ Merged **Merged:** 9/26/2024 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `bookmark-import-tag-duplication` --- ### 📝 Commits (2) - [`b21f2f7`](https://github.com/karakeep-app/karakeep/commit/b21f2f7bbe856775c434ee0dd8bdb669bfd54688) [Bug Report] Importing bookmarks adds all tags to all bookmarks #421 - [`bab891f`](https://github.com/karakeep-app/karakeep/commit/bab891f97c31200752dfaf386406f5a9b1c588e1) Add validation on the input of update tags to ensure that its not empty ### 📊 Changes **2 files changed** (+39 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/trpc/routers/bookmarks.test.ts` (+15 -0) 📝 `packages/trpc/routers/bookmarks.ts` (+24 -10) </details> ### 📄 Description fixed an issue that caused all existing tags to be assigned to a new bookmark --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 11:58:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#1620
No description provided.