[PR #256] [MERGED] Added the bookmark type to the database #1581

New issue

Closed

opened 2026-03-02 11:58:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:58:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/256
Author: @kamtschatka
Created: 6/24/2024
Status: ✅ Merged
Merged: 7/1/2024
Merged by: @MohamedBassem

Base: main ← Head: db-update

📝 Commits (4)

7442ca9 refactoring asset types
a208d45 Added the bookmark type to the database
c6001a0 add BookmarkType.UNKNWON
522d8e5 lint and remove unused function

📊 Changes

27 files changed (+1266 additions, -120 deletions)

View changed files

📝 apps/browser-extension/src/SavePage.tsx (+2 -1)
📝 apps/cli/src/commands/bookmarks.ts (+8 -5)
📝 apps/mobile/app/dashboard/add-link.tsx (+3 -1)
📝 apps/mobile/app/dashboard/add-note.tsx (+6 -1)
📝 apps/mobile/app/sharing.tsx (+3 -3)
📝 apps/mobile/components/bookmarks/BookmarkCard.tsx (+7 -6)
📝 apps/mobile/components/bookmarks/UpdatingBookmarkList.tsx (+2 -1)
📝 apps/mobile/lib/upload.ts (+2 -2)
📝 apps/web/components/dashboard/UploadDropzone.tsx (+3 -2)
📝 apps/web/components/dashboard/bookmarks/BookmarkCard.tsx (+4 -4)
📝 apps/web/components/dashboard/bookmarks/BookmarkOptions.tsx (+4 -3)
📝 apps/web/components/dashboard/bookmarks/BookmarkedTextEditor.tsx (+4 -2)
📝 apps/web/components/dashboard/bookmarks/EditorCard.tsx (+8 -4)
📝 apps/web/components/dashboard/preview/AssetContentSection.tsx (+2 -2)
📝 apps/web/components/dashboard/preview/BookmarkPreview.tsx (+6 -6)
📝 apps/web/components/dashboard/preview/EditableTitle.tsx (+4 -4)
📝 apps/web/components/dashboard/preview/LinkContentSection.tsx (+6 -2)
📝 apps/web/components/dashboard/preview/TextContentSection.tsx (+2 -2)
📝 apps/workers/crawlerWorker.ts (+6 -0)
➕ packages/db/drizzle/0025_aspiring_skaar.sql (+11 -0)

...and 7 more files

📄 Description

Introduced an enum to have better type safety
cleaned up the code and based some code on the type directly

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/256 **Author:** [@kamtschatka](https://github.com/kamtschatka) **Created:** 6/24/2024 **Status:** ✅ Merged **Merged:** 7/1/2024 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `db-update` --- ### 📝 Commits (4) - [`7442ca9`](https://github.com/karakeep-app/karakeep/commit/7442ca9a0844538db0a0167f50452e5fd16d28e6) refactoring asset types - [`a208d45`](https://github.com/karakeep-app/karakeep/commit/a208d45dfde6fdd7f0655e4b213290545176212a) Added the bookmark type to the database - [`c6001a0`](https://github.com/karakeep-app/karakeep/commit/c6001a083abf6b52f4f0a12d620aef7f6bc3d5e5) add BookmarkType.UNKNWON - [`522d8e5`](https://github.com/karakeep-app/karakeep/commit/522d8e57f83b385949910ae122c4973f38fb5564) lint and remove unused function ### 📊 Changes **27 files changed** (+1266 additions, -120 deletions) <details> <summary>View changed files</summary> 📝 `apps/browser-extension/src/SavePage.tsx` (+2 -1) 📝 `apps/cli/src/commands/bookmarks.ts` (+8 -5) 📝 `apps/mobile/app/dashboard/add-link.tsx` (+3 -1) 📝 `apps/mobile/app/dashboard/add-note.tsx` (+6 -1) 📝 `apps/mobile/app/sharing.tsx` (+3 -3) 📝 `apps/mobile/components/bookmarks/BookmarkCard.tsx` (+7 -6) 📝 `apps/mobile/components/bookmarks/UpdatingBookmarkList.tsx` (+2 -1) 📝 `apps/mobile/lib/upload.ts` (+2 -2) 📝 `apps/web/components/dashboard/UploadDropzone.tsx` (+3 -2) 📝 `apps/web/components/dashboard/bookmarks/BookmarkCard.tsx` (+4 -4) 📝 `apps/web/components/dashboard/bookmarks/BookmarkOptions.tsx` (+4 -3) 📝 `apps/web/components/dashboard/bookmarks/BookmarkedTextEditor.tsx` (+4 -2) 📝 `apps/web/components/dashboard/bookmarks/EditorCard.tsx` (+8 -4) 📝 `apps/web/components/dashboard/preview/AssetContentSection.tsx` (+2 -2) 📝 `apps/web/components/dashboard/preview/BookmarkPreview.tsx` (+6 -6) 📝 `apps/web/components/dashboard/preview/EditableTitle.tsx` (+4 -4) 📝 `apps/web/components/dashboard/preview/LinkContentSection.tsx` (+6 -2) 📝 `apps/web/components/dashboard/preview/TextContentSection.tsx` (+2 -2) 📝 `apps/workers/crawlerWorker.ts` (+6 -0) ➕ `packages/db/drizzle/0025_aspiring_skaar.sql` (+11 -0) _...and 7 more files_ </details> ### 📄 Description Introduced an enum to have better type safety cleaned up the code and based some code on the type directly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:58:16 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1581

No description provided.

Rows
Columns