[PR #253] [MERGED] refactoring asset types #1579

New issue

Closed

opened 2026-03-02 11:58:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:58:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/253
Author: @kamtschatka
Created: 6/23/2024
Status: ✅ Merged
Merged: 6/29/2024
Merged by: @MohamedBassem

Base: main ← Head: refactoring

📝 Commits (2)

e8c5fae refactoring asset types
9ca5312 revert silentDeleteAsset and hide better-sqlite3

📊 Changes

3 files changed (+80 additions, -65 deletions)

View changed files

📝 apps/workers/crawlerWorker.ts (+49 -32)
📝 packages/db/index.ts (+14 -0)
📝 packages/trpc/routers/bookmarks.ts (+17 -33)

📄 Description

Extracted out functions to silently delete assets and to update them after crawling
Generalized the mapping of assets to bookmark fields to make extending them easier

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/253 **Author:** [@kamtschatka](https://github.com/kamtschatka) **Created:** 6/23/2024 **Status:** ✅ Merged **Merged:** 6/29/2024 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `refactoring` --- ### 📝 Commits (2) - [`e8c5fae`](https://github.com/karakeep-app/karakeep/commit/e8c5fae9b73dd746e9e9c7e811ddb538b1f92453) refactoring asset types - [`9ca5312`](https://github.com/karakeep-app/karakeep/commit/9ca53128c07ef7fb5af960fdb9a965e8b9a9518e) revert silentDeleteAsset and hide better-sqlite3 ### 📊 Changes **3 files changed** (+80 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `apps/workers/crawlerWorker.ts` (+49 -32) 📝 `packages/db/index.ts` (+14 -0) 📝 `packages/trpc/routers/bookmarks.ts` (+17 -33) </details> ### 📄 Description Extracted out functions to silently delete assets and to update them after crawling Generalized the mapping of assets to bookmark fields to make extending them easier --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:58:16 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-02 11:59:30 +03:00

[PR #1579] [CLOSED] fix: prevent search list scroll position reset after bookmark interactions #1863

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1579

No description provided.

Rows
Columns