[PR #147] [MERGED] feature: Clicking preview for image assets brings up the details modal #1534

New issue

Closed

opened 2026-03-02 11:58:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:58:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/147
Author: @lilacpixel
Created: 5/10/2024
Status: ✅ Merged
Merged: 5/10/2024
Merged by: @MohamedBassem

Base: main ← Head: image-click-zoom

📝 Commits (1)

8bffabc feature: Clicking preview for image assets brings up the details modal

📊 Changes

1 file changed (+9 additions, -6 deletions)

View changed files

📝 apps/web/components/dashboard/bookmarks/AssetCard.tsx (+9 -6)

📄 Description

Hi there! Very simple tweak to make my and my spouse's lives a bit easier--as designers, we make heavy use of the ability to save images in Hoarder!

By default, link bookmarks have a clickable preview image and title, and the maximize button in the action bar opens a modal with the local text-only archive. Uploaded images don't have an external link, so clicking the preview image or title does nothing, and only clicking the maximize button opens the details modal so the full image can be viewed.

This change just makes preview images for image assets open the details modal--the same behavior as the maximize button. Makes them a little easier to hit on mobile 😸

It's my first time working with NextJS, so I hope everything looks okay. Thanks for making Hoarder; we're really enjoying it so far!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/147 **Author:** [@lilacpixel](https://github.com/lilacpixel) **Created:** 5/10/2024 **Status:** ✅ Merged **Merged:** 5/10/2024 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `image-click-zoom` --- ### 📝 Commits (1) - [`8bffabc`](https://github.com/karakeep-app/karakeep/commit/8bffabc54435da1a650a7f6ba79f587d75fbc01a) feature: Clicking preview for image assets brings up the details modal ### 📊 Changes **1 file changed** (+9 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/components/dashboard/bookmarks/AssetCard.tsx` (+9 -6) </details> ### 📄 Description Hi there! Very simple tweak to make my and my spouse's lives a bit easier--as designers, we make heavy use of the ability to save images in Hoarder! By default, link bookmarks have a clickable preview image and title, and the maximize button in the action bar opens a modal with the local text-only archive. Uploaded images don't have an external link, so clicking the preview image or title does nothing, and only clicking the maximize button opens the details modal so the full image can be viewed. This change just makes preview images for image assets open the details modal--the same behavior as the maximize button. Makes them a little easier to hit on mobile 😸 It's my first time working with NextJS, so I hope everything looks okay. Thanks for making Hoarder; we're really enjoying it so far! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:58:04 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1534

No description provided.

Rows
Columns