[GH-ISSUE #1861] FR: Show some visual indication that a full page archive (or a recrawl) is in progress #1160

Open
opened 2026-03-02 11:55:25 +03:00 by kerem · 13 comments
Owner

Originally created by @sprior on GitHub (Aug 21, 2025).
Original GitHub issue: https://github.com/karakeep-app/karakeep/issues/1861

Describe the Bug

When I go to the bookmark list I can click on the "..." on the right hand side of any item and one of the menu choices is "Download Full Page Archive", but selecting that item does nothing if that function hasn't been configured. I suggest that if the feature isn't enabled the menu item for it shouldn't appear.

Steps to Reproduce

  1. Hoard an article
  2. go to your bookmark list
  3. click on the "..." menu for an article in that list
  4. See that "Download Full Page Archive" appears as a choice even if that feature hasn't been enabled and does nothing.

Expected Behaviour

If the feature isn't enabled don't show it in the menu

Screenshots or Additional Context

No response

Device Details

Firefox 142 16 bit on Windows 11

Exact Karakeep Version

v0.26.0

Have you checked the troubleshooting guide?

  • I have checked the troubleshooting guide and I haven't found a solution to my problem
Originally created by @sprior on GitHub (Aug 21, 2025). Original GitHub issue: https://github.com/karakeep-app/karakeep/issues/1861 ### Describe the Bug When I go to the bookmark list I can click on the "..." on the right hand side of any item and one of the menu choices is "Download Full Page Archive", but selecting that item does nothing if that function hasn't been configured. I suggest that if the feature isn't enabled the menu item for it shouldn't appear. ### Steps to Reproduce 1. Hoard an article 2. go to your bookmark list 3. click on the "..." menu for an article in that list 4. See that "Download Full Page Archive" appears as a choice even if that feature hasn't been enabled and does nothing. ### Expected Behaviour If the feature isn't enabled don't show it in the menu ### Screenshots or Additional Context _No response_ ### Device Details Firefox 142 16 bit on Windows 11 ### Exact Karakeep Version v0.26.0 ### Have you checked the troubleshooting guide? - [x] I have checked the troubleshooting guide and I haven't found a solution to my problem
Author
Owner

@MohamedBassem commented on GitHub (Aug 21, 2025):

Download full page archive works even if the it's not "enabled". The config option enables "automatic" full page archive. The problem that you're observing is that there's no visual indication that the archive is being downloaded. I'll repurpose this issue to fix that insead.

<!-- gh-comment-id:3211115330 --> @MohamedBassem commented on GitHub (Aug 21, 2025): Download full page archive works even if the it's not "enabled". The config option enables "automatic" full page archive. The problem that you're observing is that there's no visual indication that the archive is being downloaded. I'll repurpose this issue to fix that insead.
Author
Owner

@sprior commented on GitHub (Aug 21, 2025):

Thanks for the response, but I'm not sure it's just a matter of an indication that the archive is being downloaded. Based on your comment I tried that menu option again and I did see a quick pop up in the lower right that a Full Archive Creation has been Triggered, but then nothing else despite me waiting for a significant time, never got to a download prompt. So as I can tell it's not just that I wasn't being notified to be patient enough.

<!-- gh-comment-id:3212266399 --> @sprior commented on GitHub (Aug 21, 2025): Thanks for the response, but I'm not sure it's just a matter of an indication that the archive is being downloaded. Based on your comment I tried that menu option again and I did see a quick pop up in the lower right that a Full Archive Creation has been Triggered, but then nothing else despite me waiting for a significant time, never got to a download prompt. So as I can tell it's not just that I wasn't being notified to be patient enough.
Author
Owner

@MohamedBassem commented on GitHub (Aug 21, 2025):

@sprior can you share the logs of your container after clicking download full page archive?

<!-- gh-comment-id:3212273946 --> @MohamedBassem commented on GitHub (Aug 21, 2025): @sprior can you share the logs of your container after clicking download full page archive?
Author
Owner

@sprior commented on GitHub (Aug 21, 2025):

And while we're close to the topic, how does this feature interact with a bookmark created with SingleFile - I'd think it would be able to just return the asset without recrawling it.

<!-- gh-comment-id:3212275704 --> @sprior commented on GitHub (Aug 21, 2025): And while we're close to the topic, how does this feature interact with a bookmark created with SingleFile - I'd think it would be able to just return the asset without recrawling it.
Author
Owner

@MohamedBassem commented on GitHub (Aug 21, 2025):

@sprior yes, if the bookmark was created with SingleFile, it won't get recrawled.

<!-- gh-comment-id:3212278800 --> @MohamedBassem commented on GitHub (Aug 21, 2025): @sprior yes, if the bookmark was created with SingleFile, it won't get recrawled.
Author
Owner

@sprior commented on GitHub (Aug 21, 2025):

I had bookmarked the page:
https://github.com/Y2Z/monolith
Actually I got interested in this because it was part of the download archive feature.

log.txt

I saw the popup that the crawl had been triggered and the log entries appear that the work was done, but I was never given a prompt to download the result despite waiting for more than 2 minutes.

I also noticed that when I tried it again the log indicates it did a brand new crawl despite already having done it before.

<!-- gh-comment-id:3212286500 --> @sprior commented on GitHub (Aug 21, 2025): I had bookmarked the page: https://github.com/Y2Z/monolith Actually I got interested in this because it was part of the download archive feature. [log.txt](https://github.com/user-attachments/files/21927137/log.txt) I saw the popup that the crawl had been triggered and the log entries appear that the work was done, but I was never given a prompt to download the result despite waiting for more than 2 minutes. I also noticed that when I tried it again the log indicates it did a brand new crawl despite already having done it before.
Author
Owner

@sprior commented on GitHub (Aug 21, 2025):

Just did it again, same result - recrawled and inferenced but no download.

log1.txt

<!-- gh-comment-id:3212291672 --> @sprior commented on GitHub (Aug 21, 2025): Just did it again, same result - recrawled and inferenced but no download. [log1.txt](https://github.com/user-attachments/files/21927169/log1.txt)
Author
Owner

@MohamedBassem commented on GitHub (Aug 21, 2025):

Oh, I understand now. When you click "download full page archive", you'll not be prompted for a download (that's poor naming from me). This "stores" the archive and attaches it to the bookmark. You can find the archives when you expand the bookmark in the attachment section:

Image
<!-- gh-comment-id:3212316752 --> @MohamedBassem commented on GitHub (Aug 21, 2025): Oh, I understand now. When you click "download full page archive", you'll not be prompted for a download (that's poor naming from me). This "stores" the archive and attaches it to the bookmark. You can find the archives when you expand the bookmark in the attachment section: <img width="700" height="410" alt="Image" src="https://github.com/user-attachments/assets/69511adf-6400-4459-a9f3-bdbf3abd6806" />
Author
Owner

@sprior commented on GitHub (Aug 21, 2025):

Oh, now I get it. I've never even noticed the way to expand the attachments before. I do think we're using the term archive for the concept of archiving the bookmark and the full page archive which can be confusing. I'd at least recommend adding to the pop up mention that when complete the available archive will be added to the attachments. I'd also recommend a warning/choice when such an archive already exists does the user really want to replace it. Also keep in mind that I invoked this archive from the bookmark list so I wasn't even in the same screen as where I'd eventually need to download that archive, maybe invoking the download archive function should open the bookmark details screen with the attachment section expanded?

<!-- gh-comment-id:3212331507 --> @sprior commented on GitHub (Aug 21, 2025): Oh, now I get it. I've never even noticed the way to expand the attachments before. I do think we're using the term archive for the concept of archiving the bookmark and the full page archive which can be confusing. I'd at least recommend adding to the pop up mention that when complete the available archive will be added to the attachments. I'd also recommend a warning/choice when such an archive already exists does the user really want to replace it. Also keep in mind that I invoked this archive from the bookmark list so I wasn't even in the same screen as where I'd eventually need to download that archive, maybe invoking the download archive function should open the bookmark details screen with the attachment section expanded?
Author
Owner

@sprior commented on GitHub (Aug 21, 2025):

To add even a little more to this, maybe add to the list creation language a way to select bookmarks which have such a full page archive as an attachment, which will naturally be a little confusing since is:archived means something completely different.

BTW none of this is intended to delay whatever the release after 0.26.0 will be that I'm excitedly waiting for :-)

<!-- gh-comment-id:3212338906 --> @sprior commented on GitHub (Aug 21, 2025): To add even a little more to this, maybe add to the list creation language a way to select bookmarks which have such a full page archive as an attachment, which will naturally be a little confusing since is:archived means something completely different. BTW none of this is intended to delay whatever the release after 0.26.0 will be that I'm excitedly waiting for :-)
Author
Owner

@MohamedBassem commented on GitHub (Aug 21, 2025):

@sprior we have an issue (https://github.com/karakeep-app/karakeep/issues/1803) to rename the "full page archive" into a different name to avoid exactly this confusion. As for the bookmark expansion, I'm planning to add the visual indicator and the fact that it's archived in the bookmark list which again should hopefully solve this confusion.

<!-- gh-comment-id:3212344163 --> @MohamedBassem commented on GitHub (Aug 21, 2025): @sprior we have an issue (https://github.com/karakeep-app/karakeep/issues/1803) to rename the "full page archive" into a different name to avoid exactly this confusion. As for the bookmark expansion, I'm planning to add the visual indicator and the fact that it's archived in the bookmark list which again should hopefully solve this confusion.
Author
Owner

@sprior commented on GitHub (Aug 21, 2025):

Thanks. By any chance is this issue (https://github.com/karakeep-app/karakeep/issues/1787) a similar situation where I'm assuming that Export Bookmarks would pop up a download dialog when in fact it's being generated in the background and stashed somewhere for retrieval?

<!-- gh-comment-id:3212366237 --> @sprior commented on GitHub (Aug 21, 2025): Thanks. By any chance is this issue (https://github.com/karakeep-app/karakeep/issues/1787) a similar situation where I'm assuming that Export Bookmarks would pop up a download dialog when in fact it's being generated in the background and stashed somewhere for retrieval?
Author
Owner

@MohamedBassem commented on GitHub (Aug 21, 2025):

@sprior let me respond on this one there.

<!-- gh-comment-id:3212378305 --> @MohamedBassem commented on GitHub (Aug 21, 2025): @sprior let me respond on this one there.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#1160
No description provided.