[PR #63] [CLOSED] Fix close button click regression from middle-click feature #66

New issue

Closed

opened 2026-03-03 16:43:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:43:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nickustinov/itsypad-macos/pull/63
Author: @nickustinov
Created: 2/26/2026
Status: ❌ Closed

Base: main ← Head: fix/close-button-click

📝 Commits (1)

9ba8155 Fix close button click regression from middle-click feature

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 Packages/Bonsplit/Sources/Bonsplit/Internal/Views/TabItemView.swift (+5 -0)

📄 Description

Fixes #62

Problem

The middle-click overlay added in v1.9.6 was blocking all mouse events, preventing the close button (X) from receiving clicks.

Solution

Added hitTest override to the MiddleClickNSView to return nil, which allows clicks to pass through to underlying views (like the close button) while still capturing middle-click events via otherMouseUp.

Testing

Close button clicks now work
Middle-click still closes tabs
Cmd+W continues to work

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nickustinov/itsypad-macos/pull/63 **Author:** [@nickustinov](https://github.com/nickustinov) **Created:** 2/26/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/close-button-click` --- ### 📝 Commits (1) - [`9ba8155`](https://github.com/nickustinov/itsypad-macos/commit/9ba81558ecfb83aa69a54ef4a0e1be72e8e43fc7) Fix close button click regression from middle-click feature ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Packages/Bonsplit/Sources/Bonsplit/Internal/Views/TabItemView.swift` (+5 -0) </details> ### 📄 Description Fixes #62 ## Problem The middle-click overlay added in v1.9.6 was blocking all mouse events, preventing the close button (X) from receiving clicks. ## Solution Added `hitTest` override to the `MiddleClickNSView` to return `nil`, which allows clicks to pass through to underlying views (like the close button) while still capturing middle-click events via `otherMouseUp`. ## Testing - Close button clicks now work - Middle-click still closes tabs - Cmd+W continues to work --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>