[GH-ISSUE #88] Refactor: Call information should be stored in a single type #61

Closed
opened 2026-03-07 19:41:27 +03:00 by kerem · 0 comments
Owner

Originally created by @mschlaipfer on GitHub (Dec 18, 2025).
Original GitHub issue: https://github.com/awslabs/iam-policy-autopilot/issues/88

We currently store call information in various types, each with small specialization, e.g., ChainedWaiterCallInfo, WaitCallInfo, etc. See attached screenshot (which might not be complete):

Image

We should refactor this so we avoid code duplication. We could have common and a specialized fields, and we should implement getters on these.

Having separate types led to a lot of duplicated work in https://github.com/awslabs/iam-policy-autopilot/pull/84.
https://github.com/awslabs/iam-policy-autopilot/pull/79 works around it (for Python waiters) by introducing a CallInfo enum, but this should be removed as part of this refactoring.

Originally created by @mschlaipfer on GitHub (Dec 18, 2025). Original GitHub issue: https://github.com/awslabs/iam-policy-autopilot/issues/88 We currently store call information in various types, each with small specialization, e.g., `ChainedWaiterCallInfo`, `WaitCallInfo`, etc. See attached screenshot (which might not be complete): <img width="291" height="329" alt="Image" src="https://github.com/user-attachments/assets/92e70cba-7403-45c2-a501-401818f81f9a" /> We should refactor this so we avoid code duplication. We could have common and a specialized fields, and we should implement getters on these. Having separate types led to a lot of duplicated work in https://github.com/awslabs/iam-policy-autopilot/pull/84. https://github.com/awslabs/iam-policy-autopilot/pull/79 works around it (for Python waiters) by introducing a `CallInfo` enum, but this should be removed as part of this refactoring.
kerem 2026-03-07 19:41:27 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/iam-policy-autopilot#61
No description provided.