[PR #144] [MERGED] chore: auto fix more `clippy` warnings #262

New issue

Closed

opened 2026-03-15 11:56:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 11:56:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/awslabs/iam-policy-autopilot/pull/144
Author: @adpaco-aws
Created: 2/6/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @adpaco-aws

Base: main ← Head: remove-lints-2

📝 Commits (10+)

dd35768 chore: fix clippy lint manual_assert
317937e chore: fix clippy lint must_use_candidate
5291604 chore: fix clippy lint needless_raw_string_hashes
14461e1 chore: fix clippy lint option_as_ref_cloned
dfd32fd chore: fix clippy lint redundant_closure_for_method_calls
a7648e0 chore: fix clippy lint semicolon_if_nothing_returned
ee59f4f chore: fix clippy lint single_match_else
549fa04 chore: fix clippy lint struct_excessive_bools
7d4fa57 chore: fix clippy lint unnecessary_semicolon
09dc3ba chore: fix clippy lint use_self

📊 Changes

42 files changed (+170 additions, -166 deletions)

View changed files

📝 Cargo.toml (+0 -12)
📝 iam-policy-autopilot-access-denied/src/aws/policy_naming.rs (+3 -1)
📝 iam-policy-autopilot-access-denied/src/aws/principal.rs (+1 -0)
📝 iam-policy-autopilot-access-denied/src/aws/sts.rs (+1 -1)
📝 iam-policy-autopilot-access-denied/src/error.rs (+1 -0)
📝 iam-policy-autopilot-access-denied/src/parsing/catalog.rs (+1 -0)
📝 iam-policy-autopilot-access-denied/src/parsing/utils.rs (+1 -0)
📝 iam-policy-autopilot-access-denied/src/synthesis/policy_builder.rs (+2 -0)
📝 iam-policy-autopilot-access-denied/src/types.rs (+3 -2)
📝 iam-policy-autopilot-cli/src/main.rs (+1 -1)
📝 iam-policy-autopilot-cli/src/types.rs (+4 -4)
📝 iam-policy-autopilot-mcp-server/src/lib.rs (+5 -5)
📝 iam-policy-autopilot-mcp-server/src/mcp.rs (+1 -1)
📝 iam-policy-autopilot-mcp-server/src/tools/fix_access_denied.rs (+1 -1)
📝 iam-policy-autopilot-mcp-server/src/tools/generate_policy.rs (+5 -1)
📝 iam-policy-autopilot-policy-generation/build.rs (+17 -19)
📝 iam-policy-autopilot-policy-generation/src/api/common.rs (+4 -1)
📝 iam-policy-autopilot-policy-generation/src/embedded_data.rs (+1 -1)
📝 iam-policy-autopilot-policy-generation/src/enrichment/mod.rs (+4 -6)
📝 iam-policy-autopilot-policy-generation/src/enrichment/operation_fas_map.rs (+2 -2)

...and 22 more files

📄 Description

Issue #, if available: Towards #136

Description of changes: Used the --fix feature from clippy to automatically fix some warnings. I did it through a script that would only commit the fixes for a clippy lint if it successfully resolved all issues automatically.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/awslabs/iam-policy-autopilot/pull/144 **Author:** [@adpaco-aws](https://github.com/adpaco-aws) **Created:** 2/6/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@adpaco-aws](https://github.com/adpaco-aws) **Base:** `main` ← **Head:** `remove-lints-2` --- ### 📝 Commits (10+) - [`dd35768`](https://github.com/awslabs/iam-policy-autopilot/commit/dd357689d89f74b1852b8c47b201246be3ac7319) chore: fix clippy lint manual_assert - [`317937e`](https://github.com/awslabs/iam-policy-autopilot/commit/317937e856e09f52360679518cd4a4a0e53e3ac0) chore: fix clippy lint must_use_candidate - [`5291604`](https://github.com/awslabs/iam-policy-autopilot/commit/529160429e96b1f97de14f8da1a2afba409ad2b5) chore: fix clippy lint needless_raw_string_hashes - [`14461e1`](https://github.com/awslabs/iam-policy-autopilot/commit/14461e14bbcda7a3338026e5c18a28e7e9ff9359) chore: fix clippy lint option_as_ref_cloned - [`dfd32fd`](https://github.com/awslabs/iam-policy-autopilot/commit/dfd32fd39c6a674583642ed1ce7a2f5358494465) chore: fix clippy lint redundant_closure_for_method_calls - [`a7648e0`](https://github.com/awslabs/iam-policy-autopilot/commit/a7648e0ce813fda0181769f4010aca2c6dae0a66) chore: fix clippy lint semicolon_if_nothing_returned - [`ee59f4f`](https://github.com/awslabs/iam-policy-autopilot/commit/ee59f4f91925cb061edee7352604bd2253795f4c) chore: fix clippy lint single_match_else - [`549fa04`](https://github.com/awslabs/iam-policy-autopilot/commit/549fa049eb1267055007584df4b19c604349f5ab) chore: fix clippy lint struct_excessive_bools - [`7d4fa57`](https://github.com/awslabs/iam-policy-autopilot/commit/7d4fa579870f5f0bdd30e67d8bf46e7063f392bc) chore: fix clippy lint unnecessary_semicolon - [`09dc3ba`](https://github.com/awslabs/iam-policy-autopilot/commit/09dc3bae2b30c568469555f2f6b37c35972d686f) chore: fix clippy lint use_self ### 📊 Changes **42 files changed** (+170 additions, -166 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+0 -12) 📝 `iam-policy-autopilot-access-denied/src/aws/policy_naming.rs` (+3 -1) 📝 `iam-policy-autopilot-access-denied/src/aws/principal.rs` (+1 -0) 📝 `iam-policy-autopilot-access-denied/src/aws/sts.rs` (+1 -1) 📝 `iam-policy-autopilot-access-denied/src/error.rs` (+1 -0) 📝 `iam-policy-autopilot-access-denied/src/parsing/catalog.rs` (+1 -0) 📝 `iam-policy-autopilot-access-denied/src/parsing/utils.rs` (+1 -0) 📝 `iam-policy-autopilot-access-denied/src/synthesis/policy_builder.rs` (+2 -0) 📝 `iam-policy-autopilot-access-denied/src/types.rs` (+3 -2) 📝 `iam-policy-autopilot-cli/src/main.rs` (+1 -1) 📝 `iam-policy-autopilot-cli/src/types.rs` (+4 -4) 📝 `iam-policy-autopilot-mcp-server/src/lib.rs` (+5 -5) 📝 `iam-policy-autopilot-mcp-server/src/mcp.rs` (+1 -1) 📝 `iam-policy-autopilot-mcp-server/src/tools/fix_access_denied.rs` (+1 -1) 📝 `iam-policy-autopilot-mcp-server/src/tools/generate_policy.rs` (+5 -1) 📝 `iam-policy-autopilot-policy-generation/build.rs` (+17 -19) 📝 `iam-policy-autopilot-policy-generation/src/api/common.rs` (+4 -1) 📝 `iam-policy-autopilot-policy-generation/src/embedded_data.rs` (+1 -1) 📝 `iam-policy-autopilot-policy-generation/src/enrichment/mod.rs` (+4 -6) 📝 `iam-policy-autopilot-policy-generation/src/enrichment/operation_fas_map.rs` (+2 -2) _...and 22 more files_ </details> ### 📄 Description *Issue #, if available:* Towards #136 *Description of changes:* Used the `--fix` feature from `clippy` to automatically fix some warnings. I did it through a script that would only commit the fixes for a `clippy` lint if it successfully resolved all issues automatically. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>