[PR #112] [MERGED] test: waiters extraction #237

New issue

Closed

opened 2026-03-15 11:55:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 11:55:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/awslabs/iam-policy-autopilot/pull/112
Author: @mschlaipfer
Created: 1/21/2026
Status: ✅ Merged
Merged: 1/28/2026
Merged by: @mschlaipfer

Base: main ← Head: test-waiter-extraction

📝 Commits (6)

d325fd0 test: waiters extraction
ab3fd38 fix comments
aaec10a Merge branch 'main' into test-waiter-extraction
4d5afe8 Merge branch 'main' into test-waiter-extraction
a58603c Merge branch 'main' into test-waiter-extraction
b9fe8ef Merge branch 'main' into test-waiter-extraction

📊 Changes

1 file changed (+817 additions, -0 deletions)

View changed files

➕ iam-policy-autopilot-policy-generation/tests/waiters_extraction.rs (+817 -0)

📄 Description

Issue #, if available: partially implements https://github.com/awslabs/iam-policy-autopilot/issues/71

Description of changes:

Adds comprehensive tests for waiter extraction. For every waiter in the botocore model, we generate one more input files in all supported languages and assert that the expected SdkMethodCall (operation + service) is extracted.

This would have caught https://github.com/awslabs/iam-policy-autopilot/issues/108.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/awslabs/iam-policy-autopilot/pull/112 **Author:** [@mschlaipfer](https://github.com/mschlaipfer) **Created:** 1/21/2026 **Status:** ✅ Merged **Merged:** 1/28/2026 **Merged by:** [@mschlaipfer](https://github.com/mschlaipfer) **Base:** `main` ← **Head:** `test-waiter-extraction` --- ### 📝 Commits (6) - [`d325fd0`](https://github.com/awslabs/iam-policy-autopilot/commit/d325fd08292bd638e38e046ac7bb0529af74a945) test: waiters extraction - [`ab3fd38`](https://github.com/awslabs/iam-policy-autopilot/commit/ab3fd38c79e5cf8d66ca0825d8170f05fb421b17) fix comments - [`aaec10a`](https://github.com/awslabs/iam-policy-autopilot/commit/aaec10afdad2b95fd3b242a54ca85bfc353a7833) Merge branch 'main' into test-waiter-extraction - [`4d5afe8`](https://github.com/awslabs/iam-policy-autopilot/commit/4d5afe8d333a1c79f2e1bc55cbcfbff5fc4a785f) Merge branch 'main' into test-waiter-extraction - [`a58603c`](https://github.com/awslabs/iam-policy-autopilot/commit/a58603c4df752f4dedf24e1b20e96d43dff7ab08) Merge branch 'main' into test-waiter-extraction - [`b9fe8ef`](https://github.com/awslabs/iam-policy-autopilot/commit/b9fe8ef3a986fc4823f8c9cf0a570c9a861ced89) Merge branch 'main' into test-waiter-extraction ### 📊 Changes **1 file changed** (+817 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `iam-policy-autopilot-policy-generation/tests/waiters_extraction.rs` (+817 -0) </details> ### 📄 Description *Issue #, if available:* partially implements https://github.com/awslabs/iam-policy-autopilot/issues/71 *Description of changes:* Adds comprehensive tests for waiter extraction. For every waiter in the botocore model, we generate one more input files in all supported languages and assert that the expected `SdkMethodCall` (operation + service) is extracted. This would have caught https://github.com/awslabs/iam-policy-autopilot/issues/108. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>