[PR #5] [MERGED] Clean up and stricter tests #160

New issue

Closed

opened 2026-03-15 11:50:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 11:50:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/awslabs/iam-policy-autopilot/pull/5
Author: @mschlaipfer
Created: 11/18/2025
Status: ✅ Merged
Merged: 11/18/2025
Merged by: @mschlaipfer

Base: prerelease ← Head: prerelease

📝 Commits (1)

05e4bf7 Clean up and stricter tests

📊 Changes

22 files changed (+128 additions, -492 deletions)

View changed files

📝 iam-policy-autopilot-access-denied/src/aws/iam_client.rs (+2 -2)
📝 iam-policy-autopilot-access-denied/src/commands/service.rs (+0 -53)
📝 iam-policy-autopilot-access-denied/src/error.rs (+1 -1)
📝 iam-policy-autopilot-access-denied/src/lib.rs (+1 -1)
📝 iam-policy-autopilot-cli/src/main.rs (+14 -36)
📝 iam-policy-autopilot-cli/tests/integration_tests.rs (+71 -29)
📝 iam-policy-autopilot-policy-generation/src/embedded_data.rs (+0 -15)
📝 iam-policy-autopilot-policy-generation/src/enrichment/engine.rs (+6 -34)
📝 iam-policy-autopilot-policy-generation/src/enrichment/mod.rs (+0 -21)
📝 iam-policy-autopilot-policy-generation/src/enrichment/operation_fas_map.rs (+0 -1)
📝 iam-policy-autopilot-policy-generation/src/enrichment/resource_matcher.rs (+2 -5)
📝 iam-policy-autopilot-policy-generation/src/extraction/engine.rs (+1 -5)
📝 iam-policy-autopilot-policy-generation/src/extraction/javascript/extractor.rs (+2 -4)
📝 iam-policy-autopilot-policy-generation/src/extraction/javascript/scanner.rs (+4 -13)
📝 iam-policy-autopilot-policy-generation/src/extraction/sdk_model.rs (+3 -3)
📝 iam-policy-autopilot-policy-generation/src/lib.rs (+0 -2)
📝 iam-policy-autopilot-policy-generation/src/providers/filesystem.rs (+4 -98)
📝 iam-policy-autopilot-policy-generation/src/providers/json.rs (+8 -71)
📝 iam-policy-autopilot-policy-generation/src/providers/mod.rs (+4 -9)
📝 iam-policy-autopilot-policy-generation/src/service_configuration.rs (+0 -1)

...and 2 more files

📄 Description

Issue #, if available: N/A

Description of changes:

Cleaned up useless tests, and searched through comments to clean up LLM-generated comments.
Stripped NativeJsonProvider and NativeFileSystemProvider of the Native prefix.
Added some CLI integration tests.
Hid the extract-sdk-calls command from the CLI, and some options like --individual-policies and --debug.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/awslabs/iam-policy-autopilot/pull/5 **Author:** [@mschlaipfer](https://github.com/mschlaipfer) **Created:** 11/18/2025 **Status:** ✅ Merged **Merged:** 11/18/2025 **Merged by:** [@mschlaipfer](https://github.com/mschlaipfer) **Base:** `prerelease` ← **Head:** `prerelease` --- ### 📝 Commits (1) - [`05e4bf7`](https://github.com/awslabs/iam-policy-autopilot/commit/05e4bf7fd09a724c30e3365b59dbbd13c84c4cff) Clean up and stricter tests ### 📊 Changes **22 files changed** (+128 additions, -492 deletions) <details> <summary>View changed files</summary> 📝 `iam-policy-autopilot-access-denied/src/aws/iam_client.rs` (+2 -2) 📝 `iam-policy-autopilot-access-denied/src/commands/service.rs` (+0 -53) 📝 `iam-policy-autopilot-access-denied/src/error.rs` (+1 -1) 📝 `iam-policy-autopilot-access-denied/src/lib.rs` (+1 -1) 📝 `iam-policy-autopilot-cli/src/main.rs` (+14 -36) 📝 `iam-policy-autopilot-cli/tests/integration_tests.rs` (+71 -29) 📝 `iam-policy-autopilot-policy-generation/src/embedded_data.rs` (+0 -15) 📝 `iam-policy-autopilot-policy-generation/src/enrichment/engine.rs` (+6 -34) 📝 `iam-policy-autopilot-policy-generation/src/enrichment/mod.rs` (+0 -21) 📝 `iam-policy-autopilot-policy-generation/src/enrichment/operation_fas_map.rs` (+0 -1) 📝 `iam-policy-autopilot-policy-generation/src/enrichment/resource_matcher.rs` (+2 -5) 📝 `iam-policy-autopilot-policy-generation/src/extraction/engine.rs` (+1 -5) 📝 `iam-policy-autopilot-policy-generation/src/extraction/javascript/extractor.rs` (+2 -4) 📝 `iam-policy-autopilot-policy-generation/src/extraction/javascript/scanner.rs` (+4 -13) 📝 `iam-policy-autopilot-policy-generation/src/extraction/sdk_model.rs` (+3 -3) 📝 `iam-policy-autopilot-policy-generation/src/lib.rs` (+0 -2) 📝 `iam-policy-autopilot-policy-generation/src/providers/filesystem.rs` (+4 -98) 📝 `iam-policy-autopilot-policy-generation/src/providers/json.rs` (+8 -71) 📝 `iam-policy-autopilot-policy-generation/src/providers/mod.rs` (+4 -9) 📝 `iam-policy-autopilot-policy-generation/src/service_configuration.rs` (+0 -1) _...and 2 more files_ </details> ### 📄 Description *Issue #, if available:* N/A *Description of changes:* * Cleaned up useless tests, and searched through comments to clean up LLM-generated comments. * Stripped `NativeJsonProvider` and `NativeFileSystemProvider` of the `Native` prefix. * Added some CLI integration tests. * Hid the `extract-sdk-calls` command from the CLI, and some options like `--individual-policies` and `--debug`. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>