[GH-ISSUE #88] Refactor: Call information should be stored in a single type #152

New issue

Closed

opened 2026-03-15 11:48:02 +03:00 by kerem · 2 comments

kerem commented

2026-03-15 11:48:02 +03:00

Owner

Originally created by @mschlaipfer on GitHub (Dec 18, 2025).
Original GitHub issue: https://github.com/awslabs/iam-policy-autopilot/issues/88

We currently store call information in various types, each with small specialization, e.g., ChainedWaiterCallInfo, WaitCallInfo, etc. See attached screenshot (which might not be complete):

We should refactor this so we avoid code duplication. We could have common and a specialized fields, and we should implement getters on these.

Having separate types led to a lot of duplicated work in https://github.com/awslabs/iam-policy-autopilot/pull/84.
https://github.com/awslabs/iam-policy-autopilot/pull/79 works around it (for Python waiters) by introducing a CallInfo enum, but this should be removed as part of this refactoring.

Originally created by @mschlaipfer on GitHub (Dec 18, 2025). Original GitHub issue: https://github.com/awslabs/iam-policy-autopilot/issues/88 We currently store call information in various types, each with small specialization, e.g., `ChainedWaiterCallInfo`, `WaitCallInfo`, etc. See attached screenshot (which might not be complete): <img width="291" height="329" alt="Image" src="https://github.com/user-attachments/assets/92e70cba-7403-45c2-a501-401818f81f9a" /> We should refactor this so we avoid code duplication. We could have common and a specialized fields, and we should implement getters on these. Having separate types led to a lot of duplicated work in https://github.com/awslabs/iam-policy-autopilot/pull/84. https://github.com/awslabs/iam-policy-autopilot/pull/79 works around it (for Python waiters) by introducing a `CallInfo` enum, but this should be removed as part of this refactoring.

kerem

2026-03-15 11:48:02 +03:00

closed this issue
added the
code-quality
label

kerem commented

2026-03-15 11:48:19 +03:00

Author

Owner

@mschlaipfer commented on GitHub (Jan 29, 2026):

@adpaco-aws I think this is done?

@mschlaipfer commented on GitHub (Jan 29, 2026): @adpaco-aws I think this is done?

kerem commented

2026-03-15 11:48:24 +03:00

Author

Owner

@adpaco-aws commented on GitHub (Jan 30, 2026):

Partially - #97 didn't remove CallInfo so I was keeping it open till we do.

@adpaco-aws commented on GitHub (Jan 30, 2026): Partially - #97 didn't remove `CallInfo` so I was keeping it open till we do.

kerem referenced this issue

2026-03-15 11:56:40 +03:00

[PR #152] [MERGED] refactor: SdkMethodCallMetadata easier to extend #265