[PR #252] [MERGED] Fix strict mode crashing on arguments assign #291

New issue

Closed

opened 2026-03-03 13:53:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 13:53:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jehna/humanify/pull/252
Author: @jehna
Created: 12/16/2024
Status: ✅ Merged
Merged: 12/16/2024
Merged by: @jehna

Base: main ← Head: fix/arguments-crash

📝 Commits (1)

e39a616 Fix strict mode crashing on arguemnts assign

📊 Changes

2 files changed (+18 additions, -1 deletions)

View changed files

📝 src/plugins/local-llm-rename/visit-all-identifiers.test.ts (+17 -0)
📝 src/plugins/local-llm-rename/visit-all-identifiers.ts (+1 -1)

📄 Description

The script was assumed to be in strict mode, which is the functionality of sourceType: "module". This is wrong, as we cannot assume that the script would be in a strict mode.

Fixes #251

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jehna/humanify/pull/252 **Author:** [@jehna](https://github.com/jehna) **Created:** 12/16/2024 **Status:** ✅ Merged **Merged:** 12/16/2024 **Merged by:** [@jehna](https://github.com/jehna) **Base:** `main` ← **Head:** `fix/arguments-crash` --- ### 📝 Commits (1) - [`e39a616`](https://github.com/jehna/humanify/commit/e39a616ceb45883b3dbf520924f621734e1534f0) Fix strict mode crashing on arguemnts assign ### 📊 Changes **2 files changed** (+18 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/plugins/local-llm-rename/visit-all-identifiers.test.ts` (+17 -0) 📝 `src/plugins/local-llm-rename/visit-all-identifiers.ts` (+1 -1) </details> ### 📄 Description The script was assumed to be in `strict` mode, which is the functionality of `sourceType: "module"`. This is wrong, as we cannot assume that the script would be in a strict mode. Fixes #251 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>