[PR #146] [MERGED] Fix rename time complexity from n² to n #200

New issue

Closed

opened 2026-03-03 13:53:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 13:53:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jehna/humanify/pull/146
Author: @jehna
Created: 10/6/2024
Status: ✅ Merged
Merged: 10/6/2024
Merged by: @jehna

Base: main ← Head: fix/complexity

📝 Commits (1)

b8745b7 Fix rename time complexity from n² to n

📊 Changes

1 file changed (+14 additions, -37 deletions)

View changed files

📝 src/plugins/local-llm-rename/visit-all-identifiers.ts (+14 -37)

📄 Description

Was doing unnecessary loops of AST, seems that it should be okay to loop the AST just once since Babel mutates the AST in place.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jehna/humanify/pull/146 **Author:** [@jehna](https://github.com/jehna) **Created:** 10/6/2024 **Status:** ✅ Merged **Merged:** 10/6/2024 **Merged by:** [@jehna](https://github.com/jehna) **Base:** `main` ← **Head:** `fix/complexity` --- ### 📝 Commits (1) - [`b8745b7`](https://github.com/jehna/humanify/commit/b8745b7599016023021fe00344f6657c687e62ff) Fix rename time complexity from n² to n ### 📊 Changes **1 file changed** (+14 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `src/plugins/local-llm-rename/visit-all-identifiers.ts` (+14 -37) </details> ### 📄 Description Was doing unnecessary loops of AST, seems that it should be okay to loop the AST just once since Babel mutates the AST in place. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>