[PR #131] [MERGED] Handle send message event in a local setup (dev. localhost) #185

Closed
opened 2026-03-03 16:37:09 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NdoleStudio/httpsms/pull/131
Author: @eriksson
Created: 3/16/2023
Status: Merged
Merged: 3/20/2023
Merged by: @AchoArnold

Base: mainHead: handle_local_event_queue


📝 Commits (3)

  • e1c8c10 handle send event in a local setup (dev. localhost)
  • 6e4e473 refactor code and create a local implementation of the PushQueue interface: InMemoryPushQueue
  • 36dc244 add missing span.End()

📊 Changes

2 files changed (+68 additions, -0 deletions)

View changed files

📝 api/pkg/di/container.go (+9 -0)
api/pkg/services/in_memory_push_queue.go (+59 -0)

📄 Description

When running in development environment, usually bound to the localhost, there is no way to use Cloud Task to trigger the internal api /events.
We can rely on an internal timeout to simulate the a task processing queue.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NdoleStudio/httpsms/pull/131 **Author:** [@eriksson](https://github.com/eriksson) **Created:** 3/16/2023 **Status:** ✅ Merged **Merged:** 3/20/2023 **Merged by:** [@AchoArnold](https://github.com/AchoArnold) **Base:** `main` ← **Head:** `handle_local_event_queue` --- ### 📝 Commits (3) - [`e1c8c10`](https://github.com/NdoleStudio/httpsms/commit/e1c8c105a8801937611c43ee3782a61585681956) handle send event in a local setup (dev. localhost) - [`6e4e473`](https://github.com/NdoleStudio/httpsms/commit/6e4e47318c5d7f4d02a11df0542d8888635bb215) refactor code and create a local implementation of the PushQueue interface: InMemoryPushQueue - [`36dc244`](https://github.com/NdoleStudio/httpsms/commit/36dc244cbf75cdd0127dc285a83c118fbdaccbe4) add missing span.End() ### 📊 Changes **2 files changed** (+68 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `api/pkg/di/container.go` (+9 -0) ➕ `api/pkg/services/in_memory_push_queue.go` (+59 -0) </details> ### 📄 Description When running in development environment, usually bound to the localhost, there is no way to use Cloud Task to trigger the internal api [/events](https://github.com/NdoleStudio/httpsms/blob/ca94a6a1e121f1ce27dbcae5be3c99492e54610f/api/pkg/handlers/events_handler.go#L46). We can rely on an internal timeout to simulate the a task processing queue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 16:37:09 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/httpsms#185
No description provided.