[PR #52] [MERGED] fixing multiple calls to add and hostsperline from being destructive #54

Closed
opened 2026-03-02 05:08:21 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/goodhosts/hostsfile/pull/52
Author: @luthermonson
Created: 10/29/2023
Status: Merged
Merged: 10/29/2023
Merged by: @luthermonson

Base: mainHead: fix-hpl


📝 Commits (1)

  • efb40e8 fixing multiple calls to add and hostsperline from being destructive

📊 Changes

2 files changed (+21 additions, -6 deletions)

View changed files

📝 hosts.go (+8 -5)
📝 hosts_test.go (+13 -1)

📄 Description

  • Add now puts new hosts into the last line it finds instead of the first
  • fixed slice copy bug

fixes #51


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/goodhosts/hostsfile/pull/52 **Author:** [@luthermonson](https://github.com/luthermonson) **Created:** 10/29/2023 **Status:** ✅ Merged **Merged:** 10/29/2023 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `fix-hpl` --- ### 📝 Commits (1) - [`efb40e8`](https://github.com/goodhosts/hostsfile/commit/efb40e8debe8214b694bbb3eba596452237933d4) fixing multiple calls to add and hostsperline from being destructive ### 📊 Changes **2 files changed** (+21 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `hosts.go` (+8 -5) 📝 `hosts_test.go` (+13 -1) </details> ### 📄 Description * `Add` now puts new hosts into the last line it finds instead of the first * fixed slice copy bug fixes #51 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem closed this issue 2026-03-02 05:08:21 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hostsfile#54
No description provided.