[PR #46] [MERGED] Maintain Comments Better #50

New issue

Closed

opened 2026-03-02 05:08:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 05:08:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/goodhosts/hostsfile/pull/46
Author: @luthermonson
Created: 10/3/2023
Status: ✅ Merged
Merged: 10/3/2023
Merged by: @luthermonson

Base: main ← Head: mamp

📝 Commits (3)

4c9e410 additional tests
bfa1e36 moved more functionality to lookups, refactored to preserve comments in the clean process
560efed moving to mage

📊 Changes

18 files changed (+632 additions, -246 deletions)

View changed files

📝 .github/workflows/ci.yml (+12 -15)
📝 .gitignore (+2 -1)
➖ Makefile (+0 -5)
➕ build.go (+6 -0)
➕ coverage.txt (+213 -0)
📝 go.mod (+6 -5)
📝 go.sum (+14 -16)
📝 hosts.go (+148 -162)
📝 hosts_test.go (+76 -8)
📝 hostsline.go (+4 -4)
➕ lookup.go (+42 -0)
➕ lookup_test.go (+15 -0)
➕ mage/install/install.go (+27 -0)
➕ mage/test/test.go (+25 -0)
➕ magefile.go (+35 -0)
➖ make.bat (+0 -27)
📝 os.go (+3 -2)
📝 os_windows.go (+4 -1)

📄 Description

comments were getting dropped during the Clean process and they are now being kept better
refactored lookups to have more functionality

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/goodhosts/hostsfile/pull/46 **Author:** [@luthermonson](https://github.com/luthermonson) **Created:** 10/3/2023 **Status:** ✅ Merged **Merged:** 10/3/2023 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `mamp` --- ### 📝 Commits (3) - [`4c9e410`](https://github.com/goodhosts/hostsfile/commit/4c9e410b2f677a5cfb17a28e238a0160779cde5f) additional tests - [`bfa1e36`](https://github.com/goodhosts/hostsfile/commit/bfa1e368c7344e9535a443d6e2b3ecf8873ab082) moved more functionality to lookups, refactored to preserve comments in the clean process - [`560efed`](https://github.com/goodhosts/hostsfile/commit/560efed26136584f4908f9684b3b8d2e3254aa8f) moving to mage ### 📊 Changes **18 files changed** (+632 additions, -246 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+12 -15) 📝 `.gitignore` (+2 -1) ➖ `Makefile` (+0 -5) ➕ `build.go` (+6 -0) ➕ `coverage.txt` (+213 -0) 📝 `go.mod` (+6 -5) 📝 `go.sum` (+14 -16) 📝 `hosts.go` (+148 -162) 📝 `hosts_test.go` (+76 -8) 📝 `hostsline.go` (+4 -4) ➕ `lookup.go` (+42 -0) ➕ `lookup_test.go` (+15 -0) ➕ `mage/install/install.go` (+27 -0) ➕ `mage/test/test.go` (+25 -0) ➕ `magefile.go` (+35 -0) ➖ `make.bat` (+0 -27) 📝 `os.go` (+3 -2) 📝 `os_windows.go` (+4 -1) </details> ### 📄 Description * comments were getting dropped during the Clean process and they are now being kept better * refactored lookups to have more functionality --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>