[PR #35] [MERGED] get the condition and slice right when removing by position wants to remove the last line #42

Closed
opened 2026-03-02 05:08:17 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/goodhosts/hostsfile/pull/35
Author: @kaespi
Created: 4/1/2022
Status: Merged
Merged: 4/7/2022
Merged by: @luthermonson

Base: mainHead: fix-remove-byposition-last-one


📝 Commits (1)

  • 0d10922 get the condition and slice right when removing by position wants to remove the last line

📊 Changes

2 files changed (+8 additions, -2 deletions)

View changed files

📝 hosts.go (+2 -2)
📝 hosts_test.go (+6 -0)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/goodhosts/hostsfile/pull/35 **Author:** [@kaespi](https://github.com/kaespi) **Created:** 4/1/2022 **Status:** ✅ Merged **Merged:** 4/7/2022 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `fix-remove-byposition-last-one` --- ### 📝 Commits (1) - [`0d10922`](https://github.com/goodhosts/hostsfile/commit/0d1092275e7313fb16a587d7a4777d65726fac2c) get the condition and slice right when removing by position wants to remove the last line ### 📊 Changes **2 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `hosts.go` (+2 -2) 📝 `hosts_test.go` (+6 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 05:08:17 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hostsfile#42
No description provided.