mirror of
https://github.com/goodhosts/hostsfile.git
synced 2026-04-27 15:35:50 +03:00
[GH-ISSUE #13] Q: Why is the position of a host on the line used? #4
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hostsfile#4
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tomjn on GitHub (Oct 16, 2020).
Original GitHub issue: https://github.com/goodhosts/hostsfile/issues/13
I'm debugging an issue that's sourced to code introduced in this commit:
github.com/goodhosts/hostsfile@57158c4acfHowever, looking at it, I see that a host is being removed based on its position in a list, which does not make sense to me.
Would it not make more sense to generate the list fresh or remove by value? This seems very fragile. Would it not make more sense to de-duplicate any entries then remove by value?
@luthermonson commented on GitHub (Oct 16, 2020):
are you talking about line 285? frankly i dont think that's needed any more as 289 stomps out Lines any way, i think that was from the first writing of that function and i left it in be accident. What is the issue youre seeing? Maybe I can step through the data you have and confirm
@tomjn commented on GitHub (Oct 16, 2020):
Another issue got raised for it at https://github.com/goodhosts/cli/issues/16