[PR #19] [MERGED] Close fd after checking it is writable #31

New issue

Closed

opened 2026-03-02 05:08:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 05:08:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/goodhosts/hostsfile/pull/19
Author: @guillaumerose
Created: 6/2/2021
Status: ✅ Merged
Merged: 6/3/2021
Merged by: @luthermonson

Base: master ← Head: master

📝 Commits (1)

8db19bc Close fd after checking it is writable

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 hosts.go (+6 -2)

📄 Description

This is particularly important for Windows: I found out that if a fd is still opened, the hosts file is not reloaded.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/goodhosts/hostsfile/pull/19 **Author:** [@guillaumerose](https://github.com/guillaumerose) **Created:** 6/2/2021 **Status:** ✅ Merged **Merged:** 6/3/2021 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`8db19bc`](https://github.com/goodhosts/hostsfile/commit/8db19bcd72789eda7ccaebb652f000ab4c7104cc) Close fd after checking it is writable ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `hosts.go` (+6 -2) </details> ### 📄 Description This is particularly important for Windows: I found out that if a fd is still opened, the hosts file is not reloaded. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>