starred/hostsfile
1
0
Fork 0
mirror of https://github.com/goodhosts/hostsfile.git synced 2026-04-27 15:35:50 +03:00
Code Issues 3 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #8] Comments are not published on Flush #3

New issue
Closed
opened 2026-03-02 05:08:02 +03:00 by kerem · 1 comment
kerem commented 2026-03-02 05:08:02 +03:00
Owner
Copy link

Originally created by @ShivalikRanaut on GitHub (Jun 8, 2020).
Original GitHub issue: https://github.com/goodhosts/hostsfile/issues/8

Hi with the new update , Comments are not published
func (l *HostsLine) ToRaw() string {
var comment string
if l.Comment != "" {
comment = fmt.Sprintf(" %s%s", commentChar, l.Comment)
}

return fmt.Sprintf("%s %s%s", l.IP, strings.Join(l.Hosts, " "), comment)

}`

can be changed to

`func (l *HostsLine) ToRaw() string {
if l.IsComment() {
return l
}
var comment string
if l.Comment != "" {
comment = fmt.Sprintf(" %s%s", commentChar, l.Comment)
}

return fmt.Sprintf("%s %s%s", l.IP, strings.Join(l.Hosts, " "), comment)

}`

Originally created by @ShivalikRanaut on GitHub (Jun 8, 2020). Original GitHub issue: https://github.com/goodhosts/hostsfile/issues/8 Hi with the new update , Comments are not published `func (l *HostsLine) ToRaw() string { ` var comment string if l.Comment != "" { comment = fmt.Sprintf(" %s%s", commentChar, l.Comment) } return fmt.Sprintf("%s %s%s", l.IP, strings.Join(l.Hosts, " "), comment) }` can be changed to `func (l *HostsLine) ToRaw() string { if l.IsComment() { return l } var comment string if l.Comment != "" { comment = fmt.Sprintf(" %s%s", commentChar, l.Comment) } return fmt.Sprintf("%s %s%s", l.IP, strings.Join(l.Hosts, " "), comment) }`
kerem closed this issue 2026-03-02 05:08:02 +03:00
kerem commented 2026-03-02 05:08:03 +03:00
Author
Owner
Copy link

@ShivalikRanaut commented on GitHub (Jun 8, 2020):

I have added a pull request for the same https://github.com/goodhosts/hostsfile/pull/9/commits

<!-- gh-comment-id:640696629 --> @ShivalikRanaut commented on GitHub (Jun 8, 2020): I have added a pull request for the same https://github.com/goodhosts/hostsfile/pull/9/commits
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.1.7
v0.1.6
v0.1.4
v0.1.3
v0.1.2
v0.1.1
v0.1.0
v0.0.10
v0.0.9
v0.0.8
v0.0.7
v0.0.6
v0.0.5
v0.0.4
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hostsfile#3
No description provided.