[GH-ISSUE #2945] [feature]: Some modals do not close when clicking outside #956

Closed
opened 2026-03-16 17:49:11 +03:00 by kerem · 2 comments
Owner

Originally created by @yuriy-sng on GitHub (Mar 8, 2023).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/2945

Is there an existing issue for this?

  • I have searched the existing issues

Summary

Closing a modal when clicking outside/on the overlay is such a common pattern for me.

In Hoppscotch, some modals follow this, some do not.

Modals that do not close:

  • Support
  • Login to Hoppscotch
  • New collection
  • Collections
  • Save as
  • ...?

Modals that do close:

  • Search
  • ...?

I understand some of those that do not close should be left as is, so no data/input is lost, but some (like "Support" or "Login to Hoppscotch") do not have this need.

Why should this be worked on?

I think it's a very common pattern

Originally created by @yuriy-sng on GitHub (Mar 8, 2023). Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/2945 ### Is there an existing issue for this? - [X] I have searched the existing issues ### Summary Closing a modal when clicking outside/on the overlay is such a common pattern for me. In Hoppscotch, some modals follow this, some do not. Modals that **do not** close: - Support - Login to Hoppscotch - New collection - Collections - Save as - ...? Modals that **do** close: - Search - ...? I understand some of those that do not close should be left as is, [so no data/input is lost](https://ux.stackexchange.com/questions/94423/should-clicking-outside-an-important-modal-close-it), but some (like "Support" or "Login to Hoppscotch") do not have this need. ### Why should this be worked on? I think it's a very [common pattern](https://ux.stackexchange.com/questions/23043/should-a-popup-lightbox-close-when-a-user-clicks-outside-of-the-box)
kerem 2026-03-16 17:49:11 +03:00
  • closed this issue
  • added the
    feature
    label
Author
Owner

@jaysoni-ash42 commented on GitHub (Apr 17, 2023):

@yuriybelike CC @AndrewBastin @liyasthomas i want to work on this issue but on which modal it should closes and on which it should not can you plz point that out?

<!-- gh-comment-id:1510708552 --> @jaysoni-ash42 commented on GitHub (Apr 17, 2023): @yuriybelike CC @AndrewBastin @liyasthomas i want to work on this issue but on which modal it should closes and on which it should not can you plz point that out?
Author
Owner

@liyasthomas commented on GitHub (Sep 1, 2023):

The platform only allows popups to be closed by clicking outside. All modals that have a deliberate action cannot be closed by clicking outside the modal because closing would break some flow or may cause data loss.

Since this is an expected behavior I'm closing this issue ticket as not planned.

<!-- gh-comment-id:1702716650 --> @liyasthomas commented on GitHub (Sep 1, 2023): The platform only allows popups to be closed by clicking outside. All modals that have a deliberate action cannot be closed by clicking outside the modal because closing would break some flow or may cause data loss. Since this is an expected behavior I'm closing this issue ticket as not planned.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#956
No description provided.