mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[GH-ISSUE #2945] [feature]: Some modals do not close when clicking outside #956
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#956
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @yuriy-sng on GitHub (Mar 8, 2023).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/2945
Is there an existing issue for this?
Summary
Closing a modal when clicking outside/on the overlay is such a common pattern for me.
In Hoppscotch, some modals follow this, some do not.
Modals that do not close:
Modals that do close:
I understand some of those that do not close should be left as is, so no data/input is lost, but some (like "Support" or "Login to Hoppscotch") do not have this need.
Why should this be worked on?
I think it's a very common pattern
@jaysoni-ash42 commented on GitHub (Apr 17, 2023):
@yuriybelike CC @AndrewBastin @liyasthomas i want to work on this issue but on which modal it should closes and on which it should not can you plz point that out?
@liyasthomas commented on GitHub (Sep 1, 2023):
The platform only allows popups to be closed by clicking outside. All modals that have a deliberate action cannot be closed by clicking outside the modal because closing would break some flow or may cause data loss.
Since this is an expected behavior I'm closing this issue ticket as not planned.