mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 08:45:58 +03:00
[GH-ISSUE #268] Code generation for Fetch request type of some methods (POST, PUT, PATCH) won't be shown #93
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#93
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @reefqi037 on GitHub (Nov 6, 2019).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/268
Describe the bug
When you try to generate fetch request type code for POST or PUT or PATCH method, the code won't be generated and TypeError log can be seen in the console log. Once the error happened, you won't be able to generate code for other methods too.
To Reproduce
Steps to reproduce the behavior:
Request MethodtoPOSTShow CodebuttonFetchfrom theRequest TypedropdownsExpected behavior
Code is generated and shown in the
Generated CodesectionScreenshots

Desktop (please complete the following information):
@liyasthomas commented on GitHub (Nov 6, 2019):
Wow! That's a critical bug.. not sure how this happened. Will investigate it ASAP. Thanks for pointing it out.
@reefqi037 commented on GitHub (Nov 6, 2019):
Yeah I've realized it from last week. Just haven't got time to verify and post it.
@liyasthomas commented on GitHub (Nov 6, 2019):
Any idea what went wrong?
@reefqi037 commented on GitHub (Nov 6, 2019):
Sorry haven't look into the details yet.
@liyasthomas commented on GitHub (Nov 6, 2019):
Okay
@liyasthomas commented on GitHub (Nov 6, 2019):
github.com/liyasthomas/postwoman@d290b25f8asolves this. Please verify bug fix. Actually this might break some users who already faced this issue causing the store to save the wrong state into vuex.For them, clearing cookies will fix the issue. Please let me know if there's any trouble.
@reefqi037 commented on GitHub (Nov 6, 2019):
Nope. I've cleared site data and perform hard reset but the issue still persist.
@liyasthomas commented on GitHub (Nov 6, 2019):
Yeah! Working on it.
@liyasthomas commented on GitHub (Nov 6, 2019):
5e424bb64dmind giving a try once more to check if the issue persist?@reefqi037 commented on GitHub (Nov 6, 2019):
Yup. This should fix the issue. Wondered if it's okay to remove the
$this.store.commitpart.@liyasthomas commented on GitHub (Nov 6, 2019):
Good.
Committing request Code to vuex was a foolish thing to do.