mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[GH-ISSUE #235] Extend syntax highlighting with ACE for pre-request script textarea #85
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#85
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nickpalenchar on GitHub (Oct 31, 2019).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/235
Originally assigned to: @AndrewBastin on GitHub.
Related to #218
Is your feature request related to a problem? Please describe.
No syntax highlighting might confuse users in pre-request scritps. It could look like they're writing in plaintext, and common typos won't be as apparent.
Describe the solution you'd like
Simple syntax highlighting. Things like basic javascript types should be highlighted. Nothing too fancy needed.
Describe alternatives you've considered
Going without, but syntax highlighting looks more l33t.
Additional context
@sblasa has done some research on this after reaching out on #91
@nickpalenchar commented on GitHub (Oct 31, 2019):
@sblasa are you still interested in taking this?
@liyasthomas commented on GitHub (Oct 31, 2019):
HighlightJS is already implemented in the PW.
Introduced in #142
https://highlightjs.org/
@sblasa commented on GitHub (Nov 1, 2019):
@liyasthomas and @nickpalenchar yes, I'm still interested in this. So, I'm using hiighlight.js instead, since highlight is already there; therefore use that. to extend syntax highlighting for pre-request script.
@liyasthomas commented on GitHub (Nov 5, 2019):
@sblasa thought I should ping you to get the latest updates on this issue...! If you need any help, ping me.
@sblasa commented on GitHub (Nov 6, 2019):
@liyasthomas Hi! I pulled down the latest changes--and running on my local. I'll ping you shortly for some help. Thanks!
@sblasa commented on GitHub (Nov 11, 2019):
@liyasthomas Hi, noticed that the reference for highlight.js will be removed from pages/index.vue with Replace highlight.js with ace editor #292 . So we probably won't use highlight.js to create the feature since it has been removed? Use Ace Editor instead? Thanks!
@liyasthomas commented on GitHub (Nov 11, 2019):
@sblasa sorry for the delayed response!
HighlightJS is being replaced with ace. Its implementation is much simpler and have out of the box support for textarea. Please use ace for pre-request scripts.
Or wait untill https://github.com/liyasthomas/postwoman/pull/292 is merged so you don't have any trouble importing lib.
@sblasa commented on GitHub (Nov 12, 2019):
@liyasthomas Okay, thanks for confirming. 👍
@liyasthomas commented on GitHub (Nov 12, 2019):
@sblasa ace is in production (master branch) now! Refer the code snippets from there.
@AndrewBastin commented on GitHub (Nov 30, 2019):
Yeah, I tried implementing two-way binding (v-model) onto the Ace Editor component (components/ace-editor.vue) but it had some issues with the re-render (cursor keeps staying in the first col of first line), so I dropped it...
Can somebody go into fixing that ? Or can we move Ace Editor stuff to a library (like a Ace Editor wrapper for Vue)
@liyasthomas commented on GitHub (Nov 30, 2019):
I think v-model doesn't work on Ace. I too tried and failed doing it.
@AndrewBastin commented on GitHub (Nov 30, 2019):
Can we look into libraries providing Vue wrappers from Ace ?
@liyasthomas commented on GitHub (Nov 30, 2019):
@AndrewBastin https://stackoverflow.com/questions/57645961/vue-apply-v-model-on-user-defined-component-which-use-ace-editor there's a sollution.
@AndrewBastin commented on GitHub (Nov 30, 2019):
Ooooh, if nobody is working on it, I will try implementing it and migrate the necessary views.
If nobody is working on it, can I get an assign ?