starred/hoppscotch

Fork 0

mirror of https://github.com/hoppscotch/hoppscotch.git synced 2026-04-25 16:55:59 +03:00

[GH-ISSUE #2431] [bug]: Selecting a request twice from collection removes save context #823

New issue

Closed

opened 2026-03-16 17:20:05 +03:00 by kerem · 3 comments

kerem commented

2026-03-16 17:20:05 +03:00

Owner

Originally created by @vaugenwake on GitHub (Jun 16, 2022).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/2431

Is there an existing issue for this?

I have searched the existing issues

Current behavior

When a user switches from one http request to another the save context is kept up to date and is switched correctly. When you select the same request again and there are no changes to the request, the save context is cleared, and selected state is removed from the request in the collection view as well as the active object is null.

Later if you make a change to the request you are working on and click save, you are presented with the "Save As" dialog which is incorrect. As you do not want to copy/create a new request, you want to just save the request you where already working on.

Steps to reproduce

Go to collections
Create a new collection
Create 2-3 new requests and save them in your collection
Select a request to work on
Select the same request again without go to another
Make a change, and try to save the request

Environment

Production

Version

Cloud

Originally created by @vaugenwake on GitHub (Jun 16, 2022). Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/2431 ### Is there an existing issue for this? - [X] I have searched the existing issues ### Current behavior When a user switches from one http request to another the save context is kept up to date and is switched correctly. When you select the same request again and there are no changes to the request, the save context is cleared, and selected state is removed from the request in the collection view as well as the active object is `null`. Later if you make a change to the request you are working on and click save, you are presented with the "Save As" dialog which is incorrect. As you do not want to copy/create a new request, you want to just save the request you where already working on. ### Steps to reproduce 1. Go to collections 2. Create a new collection 3. Create 2-3 new requests and save them in your collection 4. Select a request to work on 5. Select the same request again without go to another 6. Make a change, and try to save the request ### Environment Production ### Version Cloud

kerem

2026-03-16 17:20:05 +03:00

closed this issue
added the
bug

need testing
labels

kerem commented

2026-03-16 17:20:21 +03:00

Author

Owner

@AndrewBastin commented on GitHub (Jun 18, 2022):

This is an intended behaviour.

Clicking on the request when it is already selected dissociates the current editor save context from the request.
Clicking again brings it back to the context. We keep this for now to allow people to opt out of save contexts, in case they are playing around and don't want to accidentally modify a saved request.

I think changing the behaviour and moving the dissociation to the overflow menu or something will be a better solution. But we are starting to prioritize Tab System implementation (finally!) and we will be getting rid of this weird mechanism there by moving save context into a "Session Tab".

Hence, closing this and the associated PR as won't fix.

@AndrewBastin commented on GitHub (Jun 18, 2022): This is an intended behaviour. Clicking on the request when it is already selected dissociates the current editor save context from the request. Clicking again brings it back to the context. We keep this for now to allow people to opt out of save contexts, in case they are playing around and don't want to accidentally modify a saved request. I think changing the behaviour and moving the dissociation to the overflow menu or something will be a better solution. But we are starting to prioritize Tab System implementation (finally!) and we will be getting rid of this weird mechanism there by moving save context into a "Session Tab". Hence, closing this and the associated PR as won't fix.

kerem commented

2026-03-16 17:20:26 +03:00

Author

Owner

@vaugenwake commented on GitHub (Jun 18, 2022):

@AndrewBastin was not aware it was intended behavior, but thank you for clarifying.

I would support a change to this to have a more understandable user experience as many in my team & company have noted an inconsistency with saving their requests which promted the PR.

Thanks for taking the time to concider it!

@vaugenwake commented on GitHub (Jun 18, 2022): @AndrewBastin was not aware it was intended behavior, but thank you for clarifying. I would support a change to this to have a more understandable user experience as many in my team & company have noted an inconsistency with saving their requests which promted the PR. Thanks for taking the time to concider it!

kerem commented

2026-03-16 17:20:31 +03:00

Author

Owner

@AndrewBastin commented on GitHub (Jun 18, 2022):

@vaugenwake thanks to you for putting in the effort to fix it! <3

As I said, we do acknowledge the issue, we are working towards implementing a Tab System which will encapsulate the "save context"-ness of open editor requests.

I can't exactly give a timeline for it, but once it is implemented, we will be able to get rid of this weird quirk once and for all.

@AndrewBastin commented on GitHub (Jun 18, 2022): @vaugenwake thanks to you for putting in the effort to fix it! <3 As I said, we do acknowledge the issue, we are working towards implementing a Tab System which will encapsulate the "save context"-ness of open editor requests. I can't exactly give a timeline for it, but once it is implemented, we will be able to get rid of this weird quirk once and for all.

kerem referenced this issue

2026-03-17 00:32:59 +03:00

[PR #823] [MERGED] chore(config): delete render option #2884