[GH-ISSUE #2132] [bug]: Save option overrides the request name #716

Closed
opened 2026-03-16 16:50:39 +03:00 by kerem · 6 comments
Owner

Originally created by @kyteinsky on GitHub (Feb 25, 2022).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/2132

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

What I've been going through:

When I have a REST request saved in a collection with a certain name xyz, and I change some parameters of the request and then save it again the name of the request inside the collection is changed to Untitled request.

What I expected to happen:

The request should've been saved with the same name (xyz).

Steps to reproduce

  1. Import a request using cURL
  2. Save a REST request with a name other than Untitled request
  3. Change the request
  4. Save it again

Environment

Production

Version

Local

Originally created by @kyteinsky on GitHub (Feb 25, 2022). Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/2132 ### Is there an existing issue for this? - [X] I have searched the existing issues ### Current behavior ##### What I've been going through: When I have a REST request saved in a collection with a certain name `xyz`, and I change some parameters of the request and then save it again the name of the request inside the collection is changed to `Untitled request`. ##### What I expected to happen: The request should've been saved with the same name (`xyz`). ### Steps to reproduce 1. Import a request using cURL 2. Save a REST request with a name other than `Untitled request` 3. Change the request 4. Save it again ### Environment Production ### Version Local
kerem 2026-03-16 16:50:39 +03:00
Author
Owner

@AndrewBastin commented on GitHub (Feb 26, 2022):

Huh, I wasn't able to reproduce this on my end.

@liyasthomas ?

<!-- gh-comment-id:1051767722 --> @AndrewBastin commented on GitHub (Feb 26, 2022): Huh, I wasn't able to reproduce this on my end. @liyasthomas ?
Author
Owner

@liyasthomas commented on GitHub (Feb 26, 2022):

Same here. Can't reproduce this issue.

I suppose user might've reset the request (CMD+I) which will reset the request name to Untitled request.

<!-- gh-comment-id:1051777354 --> @liyasthomas commented on GitHub (Feb 26, 2022): Same here. Can't reproduce this issue. I suppose user might've reset the request (<kbd>CMD</kbd>+<kbd>I</kbd>) which will reset the request name to `Untitled request`.
Author
Owner

@kyteinsky commented on GitHub (Feb 26, 2022):

I suppose user might've reset the request (CMD+I) which will reset the request name to Untitled request.

Nope, I checked it again and am able to reproduce the issue. This name Untitled request comes from makeRESTRequest in curlparser.ts from the name key. I will upload a video after some time.

<!-- gh-comment-id:1051804039 --> @kyteinsky commented on GitHub (Feb 26, 2022): > I suppose user might've reset the request (CMD+I) which will reset the request name to `Untitled request`. Nope, I checked it again and am able to reproduce the issue. This name `Untitled request` comes from `makeRESTRequest` in `curlparser.ts` from the name key. I will upload a video after some time.
Author
Owner
<!-- gh-comment-id:1053236140 --> @kyteinsky commented on GitHub (Feb 27, 2022): https://user-images.githubusercontent.com/20724224/155871257-8a32d5c6-07b2-4b67-b20e-fec41c94eb8d.mp4
Author
Owner

@AndrewBastin commented on GitHub (Feb 27, 2022):

Oh okay.

Now, to be honest, I have found many issues with the Curl Implementation after the PR was merged. We might have to work on a continuing PR to rethink and reorganize some bits. This time with stronger standards and testing implementation to reinforce things are working properly.

<!-- gh-comment-id:1053403890 --> @AndrewBastin commented on GitHub (Feb 27, 2022): Oh okay. Now, to be honest, I have found many issues with the Curl Implementation after the PR was merged. We might have to work on a continuing PR to rethink and reorganize some bits. This time with stronger standards and testing implementation to reinforce things are working properly.
Author
Owner

@kyteinsky commented on GitHub (Feb 27, 2022):

I did test the curl parser extensively, but this definitely calls for thorough tests to be written.

With that aside, I don't believe this issue has to do anything with that PR. makeRESTRequest and setRESTRequest are causing this to happen. I need some more time to look through it.

<!-- gh-comment-id:1053572200 --> @kyteinsky commented on GitHub (Feb 27, 2022): I did test the curl parser extensively, but this definitely calls for thorough tests to be written. With that aside, I don't believe this issue has to do anything with that PR. `makeRESTRequest` and `setRESTRequest` are causing this to happen. I need some more time to look through it.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#716
No description provided.