mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[GH-ISSUE #2132] [bug]: Save option overrides the request name #716
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#716
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kyteinsky on GitHub (Feb 25, 2022).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/2132
Is there an existing issue for this?
Current behavior
What I've been going through:
When I have a REST request saved in a collection with a certain name
xyz, and I change some parameters of the request and then save it again the name of the request inside the collection is changed toUntitled request.What I expected to happen:
The request should've been saved with the same name (
xyz).Steps to reproduce
Untitled requestEnvironment
Production
Version
Local
@AndrewBastin commented on GitHub (Feb 26, 2022):
Huh, I wasn't able to reproduce this on my end.
@liyasthomas ?
@liyasthomas commented on GitHub (Feb 26, 2022):
Same here. Can't reproduce this issue.
I suppose user might've reset the request (CMD+I) which will reset the request name to
Untitled request.@kyteinsky commented on GitHub (Feb 26, 2022):
Nope, I checked it again and am able to reproduce the issue. This name
Untitled requestcomes frommakeRESTRequestincurlparser.tsfrom the name key. I will upload a video after some time.@kyteinsky commented on GitHub (Feb 27, 2022):
https://user-images.githubusercontent.com/20724224/155871257-8a32d5c6-07b2-4b67-b20e-fec41c94eb8d.mp4
@AndrewBastin commented on GitHub (Feb 27, 2022):
Oh okay.
Now, to be honest, I have found many issues with the Curl Implementation after the PR was merged. We might have to work on a continuing PR to rethink and reorganize some bits. This time with stronger standards and testing implementation to reinforce things are working properly.
@kyteinsky commented on GitHub (Feb 27, 2022):
I did test the curl parser extensively, but this definitely calls for thorough tests to be written.
With that aside, I don't believe this issue has to do anything with that PR.
makeRESTRequestandsetRESTRequestare causing this to happen. I need some more time to look through it.