[PR #5972] feat: add MAILER_SMTP_IGNORE_TLS and optional SMTP auth #5440

Open
opened 2026-03-17 02:52:57 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5972
Author: @mirarifhasan
Created: 3/11/2026
Status: 🔄 Open

Base: nextHead: feat/smtp-optional-auth


📝 Commits (1)

  • c02cea5 feat: add MAILER_SMTP_IGNORE_TLS and optional SMTP auth

📊 Changes

5 files changed (+30 additions, -13 deletions)

View changed files

📝 packages/hoppscotch-backend/src/infra-config/dto/onboarding.dto.ts (+7 -0)
📝 packages/hoppscotch-backend/src/infra-config/helper.ts (+5 -2)
📝 packages/hoppscotch-backend/src/infra-config/infra-config.service.ts (+1 -4)
📝 packages/hoppscotch-backend/src/mailer/helper.ts (+16 -7)
📝 packages/hoppscotch-backend/src/types/InfraConfig.ts (+1 -0)

📄 Description

Closes BE-714

What's changed

This PR improves the flexibility of the SMTP mailer configuration.

  • MAILER_SMTP_USER and MAILER_SMTP_PASSWORD are now optional. These fields can be left empty from the UI if authentication is not required.
  • Added support for an optional MAILER_SMTP_IGNORE_TLS configuration.

The onboarding UI and the Admin SMTP configuration tab have been updated to reflect these changes.

Notes to reviewers

Nil


Summary by cubic

Make SMTP auth optional and add MAILER_SMTP_IGNORE_TLS to support servers without auth or TLS. Updates UI and config validation to match. Closes BE-714.

  • New Features
    • Optional SMTP auth: MAILER_SMTP_USER/MAILER_SMTP_PASSWORD can be empty; transport sets auth only when provided.
    • Added MAILER_SMTP_IGNORE_TLS (default false) and wired to transport ignoreTLS.
    • Updated onboarding and Admin SMTP UI, validation, and defaults; removed user/password from required SMTP keys.

Written for commit c02cea5c0a8efea116d2cd6cf77a79f98a32e4a2. Summary will update on new commits.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5972 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 3/11/2026 **Status:** 🔄 Open **Base:** `next` ← **Head:** `feat/smtp-optional-auth` --- ### 📝 Commits (1) - [`c02cea5`](https://github.com/hoppscotch/hoppscotch/commit/c02cea5c0a8efea116d2cd6cf77a79f98a32e4a2) feat: add MAILER_SMTP_IGNORE_TLS and optional SMTP auth ### 📊 Changes **5 files changed** (+30 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/infra-config/dto/onboarding.dto.ts` (+7 -0) 📝 `packages/hoppscotch-backend/src/infra-config/helper.ts` (+5 -2) 📝 `packages/hoppscotch-backend/src/infra-config/infra-config.service.ts` (+1 -4) 📝 `packages/hoppscotch-backend/src/mailer/helper.ts` (+16 -7) 📝 `packages/hoppscotch-backend/src/types/InfraConfig.ts` (+1 -0) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> <!-- Issue # here --> Closes BE-714 <!-- Add an introduction into what this PR tries to solve in a couple of sentences --> ### What's changed <!-- Describe point by point the different things you have changed in this PR --> This PR improves the flexibility of the SMTP mailer configuration. - `MAILER_SMTP_USER` and `MAILER_SMTP_PASSWORD` are now optional. These fields can be left empty from the UI if authentication is not required. - Added support for an optional `MAILER_SMTP_IGNORE_TLS` configuration. **The onboarding UI and the Admin SMTP configuration tab have been updated to reflect these changes.** <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> ### Notes to reviewers <!-- Any information you feel the reviewer should know about when reviewing your PR --> Nil <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Make SMTP auth optional and add `MAILER_SMTP_IGNORE_TLS` to support servers without auth or TLS. Updates UI and config validation to match. Closes BE-714. - **New Features** - Optional SMTP auth: `MAILER_SMTP_USER`/`MAILER_SMTP_PASSWORD` can be empty; transport sets `auth` only when provided. - Added `MAILER_SMTP_IGNORE_TLS` (default `false`) and wired to transport `ignoreTLS`. - Updated onboarding and Admin SMTP UI, validation, and defaults; removed user/password from required SMTP keys. <sup>Written for commit c02cea5c0a8efea116d2cd6cf77a79f98a32e4a2. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#5440
No description provided.