[PR #5692] [CLOSED] fix(collection): error when opened imported collection #5320

New issue

Closed

opened 2026-03-17 02:46:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:46:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5692
Author: @akhmadkhasan68
Created: 12/12/2025
Status: ❌ Closed

Base: main ← Head: fix/open-imported-collection

📝 Commits (1)

9e6c599 fix[collection]: error when opened impoerted collection

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts (+1 -1)

📄 Description

Closes #5674 #5670 #5690

Fix team request selection error after updates and Postman Collection v2.1 imports. The problem is:

Imported Postman Collection v2.1 requests appear in sidebar but fail to load in editor when clicked
Browser console shows: TypeError: Cannot create property 'auth' on string
Error occurs because request object is stored as JSON string but not properly parsed

Root cause of this problem is Missing translateToNewRequest() call in the teamRequestUpdated$ subscription handler (line 796 of TeamCollectionAdapter.ts). When team requests are updated, the request data is parsed from JSON but not translated to ensure schema compatibility.

What's changed

Solution:

Wrap JSON.parse() with translateToNewRequest() to match the pattern used in other handlers (add, move, initial load) on file packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts

  // Before
  request: JSON.parse(result.right.teamRequestUpdated.request)

  // After
  request:
  translateToNewRequest(JSON.parse(result.right.teamRequestUpdated.request))

Impact

✅ Imported Postman collections now load correctly in editor
✅ Updated team requests can be selected without errors
✅ Ensures backward compatibility with older request schema versions

Files Changed

packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts (line 796)

Evidence before changes reproduced on Hoppscotch cloud version at https://hoppscotch.io:

Evidence step after the changes:

Import the collection from OpenAPI format file

Open the one of endpoint imported (success)

Notes to reviewers

Summary by cubic

Fixes errors when opening imported collections by normalizing updated team requests to the new request format. OpenAPI-imported endpoints now open reliably.

Bug Fixes
- Translate parsed teamRequestUpdated.request with translateToNewRequest(...) before updating to align legacy/imported payloads with the current schema.

^{Written for commit 9e6c599c68. Summary will update automatically on new commits.}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5692 **Author:** [@akhmadkhasan68](https://github.com/akhmadkhasan68) **Created:** 12/12/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/open-imported-collection` --- ### 📝 Commits (1) - [`9e6c599`](https://github.com/hoppscotch/hoppscotch/commit/9e6c599c68b1ba9b6d4d793f227d36e7cd85d485) fix[collection]: error when opened impoerted collection ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts` (+1 -1) </details> ### 📄 Description   Closes #5674 #5670 #5690 Fix team request selection error after updates and Postman Collection v2.1 imports. The problem is: * Imported Postman Collection v2.1 requests appear in sidebar but fail to load in editor when clicked * Browser console shows: `TypeError: Cannot create property 'auth' on string` * Error occurs because request object is stored as JSON string but not properly parsed Root cause of this problem is Missing `translateToNewRequest()` call in the `teamRequestUpdated$` subscription handler (line 796 of TeamCollectionAdapter.ts). When team requests are updated, the request data is parsed from JSON but not translated to ensure schema compatibility. ### What's changed Solution: * Wrap `JSON.parse()` with `translateToNewRequest()` to match the pattern used in other handlers (add, move, initial load) on file `packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts` ```typescript // Before request: JSON.parse(result.right.teamRequestUpdated.request) // After request: translateToNewRequest(JSON.parse(result.right.teamRequestUpdated.request)) ``` Impact - ✅ Imported Postman collections now load correctly in editor - ✅ Updated team requests can be selected without errors - ✅ Ensures backward compatibility with older request schema versions Files Changed - `packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts (line 796)` Evidence before changes reproduced on Hoppscotch cloud version at https://hoppscotch.io: <img width="1278" height="828" alt="image" src="https://github.com/user-attachments/assets/7bb01818-ec7c-4544-8082-240a788d1562" /> Evidence step after the changes: 1. Import the collection from OpenAPI format file <img width="1305" height="740" alt="image" src="https://github.com/user-attachments/assets/f84fe256-7cd0-4456-864c-239742c7268a" /> <img width="1276" height="790" alt="image" src="https://github.com/user-attachments/assets/fb8d4bc0-e556-4f96-b4df-51483a0d4440" /> 2. Open the one of endpoint imported (success) <img width="1300" height="792" alt="image" src="https://github.com/user-attachments/assets/b533245c-a1d6-4eba-abaa-784966882e1e" /> ### Notes to reviewers   --- ## Summary by cubic Fixes errors when opening imported collections by normalizing updated team requests to the new request format. OpenAPI-imported endpoints now open reliably. - **Bug Fixes** - Translate parsed teamRequestUpdated.request with translateToNewRequest(...) before updating to align legacy/imported payloads with the current schema. <sup>Written for commit 9e6c599c68b1ba9b6d4d793f227d36e7cd85d485. Summary will update automatically on new commits.</sup>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>