[PR #5584] [MERGED] fix: resolve collection variable referencing issues #5266

New issue

Closed

opened 2026-03-17 02:43:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:43:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5584
Author: @nivedin
Created: 11/16/2025
Status: ✅ Merged
Merged: 11/24/2025
Merged by: @jamesgeorge007

Base: next ← Head: fix/coll-var-codegen-bug

📝 Commits (3)

55fa22d chore: pass self coll environments
5a5a9f6 chore: pass coll var in codegen and cleanup
9296788 chore: cleanup

📊 Changes

3 files changed (+124 additions, -62 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/collections/Variables.vue (+8 -1)
📝 packages/hoppscotch-common/src/components/http/Codegen.vue (+115 -60)
📝 packages/hoppscotch-common/src/helpers/RequestRunner.ts (+1 -1)

📄 Description

Closes FE-1052 #5583

This PR fixes the issue where a collection could not self-reference variables within its properties. It also resolves an issue in codegen where collection variables were not being parsed correctly.

What's changed

Notes to reviewers

Summary by cubic

Fixes FE-1052/#5583 by allowing collections to self-reference their own variables and by making codegen correctly resolve collection variables alongside request and environment variables.

Bug Fixes
- Exposes current collection variables in Variables.vue (with correct source) and orders them before inherited and global envs so self-references work.
- Codegen builds a single final environment: request vars → collection vars → environment vars, filters empties, and resolves body/headers using that environment.
- Correctly applies inherited auth and headers; adds safer error handling; exports filterNonEmptyEnvironmentVariables for reuse.

^{Written for commit 9296788860. Summary will update automatically on new commits.}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5584 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 11/16/2025 **Status:** ✅ Merged **Merged:** 11/24/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/coll-var-codegen-bug` --- ### 📝 Commits (3) - [`55fa22d`](https://github.com/hoppscotch/hoppscotch/commit/55fa22de2da9cc878402509364e70d10132a63b6) chore: pass self coll environments - [`5a5a9f6`](https://github.com/hoppscotch/hoppscotch/commit/5a5a9f69171e1394f76a4b8b7c1a2ea81cd87465) chore: pass coll var in codegen and cleanup - [`9296788`](https://github.com/hoppscotch/hoppscotch/commit/9296788860333d19dfa0988295619c5b185d5897) chore: cleanup ### 📊 Changes **3 files changed** (+124 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/collections/Variables.vue` (+8 -1) 📝 `packages/hoppscotch-common/src/components/http/Codegen.vue` (+115 -60) 📝 `packages/hoppscotch-common/src/helpers/RequestRunner.ts` (+1 -1) </details> ### 📄 Description   Closes FE-1052 #5583 This PR fixes the issue where a collection could not self-reference variables within its properties. It also resolves an issue in codegen where collection variables were not being parsed correctly. ### What's changed   ### Notes to reviewers   --- ## Summary by cubic Fixes FE-1052/#5583 by allowing collections to self-reference their own variables and by making codegen correctly resolve collection variables alongside request and environment variables. - **Bug Fixes** - Exposes current collection variables in Variables.vue (with correct source) and orders them before inherited and global envs so self-references work. - Codegen builds a single final environment: request vars → collection vars → environment vars, filters empties, and resolves body/headers using that environment. - Correctly applies inherited auth and headers; adds safer error handling; exports filterNonEmptyEnvironmentVariables for reuse. <sup>Written for commit 9296788860333d19dfa0988295619c5b185d5897. Summary will update automatically on new commits.</sup>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>